Skip to content

[HDRP] [LightExplorer] Fix missing refreshwhen editing property with a running paused editor. #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2021
Merged

[HDRP] [LightExplorer] Fix missing refreshwhen editing property with a running paused editor. #5321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22cba25
Update HDLightExplorerExtension.cs
RSlysz Aug 9, 2021
4dddac1
Update CHANGELOG.md
RSlysz Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed incorrect light list indexing when TAA is enabled (case 1352444).
- Fixed Additional Velocity for Alembic not taking correctly into account vertex animation
- Fixed wrong LUT initialization in Wireframe mode.
- Fixed case where the SceneView don't refresh when using LightExplorer with a running and Paused game (1354129)

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
12 changes: 12 additions & 0 deletions com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightExplorerExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,10 @@ protected virtual LightingExplorerTableColumn[] GetHDLightColumns()
{
Undo.RecordObject(lightData, "Changed contact shadow override");
useContactShadow.@override = overrideUseContactShadows;

//SceneView don't update when interacting with Light Explorer when playing and pausing (1354129)
if (EditorApplication.isPlaying && EditorApplication.isPaused)
SceneView.RepaintAll();
}
}
else
Expand Down Expand Up @@ -640,6 +644,10 @@ protected virtual LightingExplorerTableColumn[] GetHDLightColumns()
{
Undo.RecordObject(lightData, "Changed affects diffuse");
lightData.affectDiffuse = affectDiffuse;

//SceneView don't update when interacting with Light Explorer when playing and pausing (1354129)
if (EditorApplication.isPlaying && EditorApplication.isPaused)
SceneView.RepaintAll();
}
}, (lprop, rprop) =>
{
Expand Down Expand Up @@ -674,6 +682,10 @@ protected virtual LightingExplorerTableColumn[] GetHDLightColumns()
{
Undo.RecordObject(lightData, "Changed affects specular");
lightData.affectSpecular = affectSpecular;

//SceneView don't update when interacting with Light Explorer when playing and pausing (1354129)
if (EditorApplication.isPlaying && EditorApplication.isPaused)
SceneView.RepaintAll();
}
}, (lprop, rprop) =>
{
Expand Down