Skip to content

Commit b306e57

Browse files
authored
[HDRP] [LightExplorer] Fix missing refreshwhen editing property with a running paused editor. (#5321)
* Update HDLightExplorerExtension.cs * Update CHANGELOG.md
1 parent 452a1ab commit b306e57

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

com.unity.render-pipelines.high-definition/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
359359
- Fixed incorrect light list indexing when TAA is enabled (case 1352444).
360360
- Fixed Additional Velocity for Alembic not taking correctly into account vertex animation
361361
- Fixed wrong LUT initialization in Wireframe mode.
362+
- Fixed case where the SceneView don't refresh when using LightExplorer with a running and Paused game (1354129)
362363

363364
### Changed
364365
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard

com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightExplorerExtension.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -581,6 +581,10 @@ protected virtual LightingExplorerTableColumn[] GetHDLightColumns()
581581
{
582582
Undo.RecordObject(lightData, "Changed contact shadow override");
583583
useContactShadow.@override = overrideUseContactShadows;
584+
585+
//SceneView don't update when interacting with Light Explorer when playing and pausing (1354129)
586+
if (EditorApplication.isPlaying && EditorApplication.isPaused)
587+
SceneView.RepaintAll();
584588
}
585589
}
586590
else
@@ -640,6 +644,10 @@ protected virtual LightingExplorerTableColumn[] GetHDLightColumns()
640644
{
641645
Undo.RecordObject(lightData, "Changed affects diffuse");
642646
lightData.affectDiffuse = affectDiffuse;
647+
648+
//SceneView don't update when interacting with Light Explorer when playing and pausing (1354129)
649+
if (EditorApplication.isPlaying && EditorApplication.isPaused)
650+
SceneView.RepaintAll();
643651
}
644652
}, (lprop, rprop) =>
645653
{
@@ -674,6 +682,10 @@ protected virtual LightingExplorerTableColumn[] GetHDLightColumns()
674682
{
675683
Undo.RecordObject(lightData, "Changed affects specular");
676684
lightData.affectSpecular = affectSpecular;
685+
686+
//SceneView don't update when interacting with Light Explorer when playing and pausing (1354129)
687+
if (EditorApplication.isPlaying && EditorApplication.isPaused)
688+
SceneView.RepaintAll();
677689
}
678690
}, (lprop, rprop) =>
679691
{

0 commit comments

Comments
 (0)