Fix LitTessellation heightmap displacement with planar and triplanar mapping #4911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix AxF debug output in certain configurations. * Update comment
* Fix white flash * changelog Co-authored-by: sebastienlagarde <[email protected]>
* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <[email protected]>
…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <[email protected]>
* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <[email protected]>
…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <[email protected]>
* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <[email protected]>
* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <[email protected]> Co-authored-by: sebastienlagarde <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>
…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <[email protected]>
…ing only the RTSSS Data (case 1332904). (#4626) * Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). * Add test scene Co-authored-by: Remi Chapelain <[email protected]> Co-authored-by: Sebastien Lagarde <[email protected]>
…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <[email protected]>
#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <[email protected]>
* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <[email protected]>
* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <[email protected]>
* Fix * changelog Co-authored-by: sebastienlagarde <[email protected]>
…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <[email protected]>
… and color shadows (case 1340234). (#4756) * Fixed the transparent cutoff not working properly in semi-transparent and color shadows (case 1340234). * Update test ref image Co-authored-by: Remi Chapelain <[email protected]> Co-authored-by: sebastienlagarde <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>
…n using recorder (#4856) * Make sure sky settings are correctly set when recording. * Updated changelog. Co-authored-by: sebastienlagarde <[email protected]>
* Add the necesarry texture coordinate clamping for RTHandle for color pyramid sampling * Add some resolution independence, fitted for 1920x1080 * Changelog * Switch back to point sampling from trilinear, with commentary * Update test reference images * Small correction to the point sampling, always sample mip 0. * Re-update the test images, for mip 0 color sampling * Use a simpler UV scaling/clamping since we are now point sampling. Co-authored-by: sebastienlagarde <[email protected]>
Contributor
Author
|
I need to make a different scene as the repro scene was not covering all issues and I misunderstood the degree of the issue. Code fix is correct, but more can be done in testing. Adding it now. |
Contributor
|
Testing is sufficient, but looks like yamato is completely failing, DX12 that actually manages to run tests skips this test scene. |
sebastienlagarde
approved these changes
Jun 16, 2021
Contributor
|
Currently DX12 yamato is good. All the issue are instability (like all the other builder), go to merge |
Contributor
|
ah sorry I see we need to regenerate pcitures, laaunching Yamato |
Contributor
Author
|
Argh yeah sorry forgot to re-kick the jobs myself as the one I triggered failed for unrelated reasons. |
sebastienlagarde
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://fogbugz.unity3d.com/f/cases/1342302/
There was an issue with keywords that removed the planar and triplanar mapping calculations from domain shaders, which would of course lead to problems.
This is fixed and is also adding a test with displacement with the various mapping.
I am going to be running yamato to get the ref images.
Before
After
