Platform/dx12/vfx rwbuffer fix #3797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienf-unity
approved these changes
Mar 9, 2021
sebastienlagarde
approved these changes
Mar 9, 2021
Contributor
|
Thanks for the fix @Adrian1066. Spotlight logged a bug regarding this: https://fogbugz.unity3d.com/f/cases/1318400/ |
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 9, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Use RWStructuredBuffer for strip data * Update CHANGELOG.md
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 25, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Mar 26, 2021
* Updating raytracing #include files to match the case they are on disk so that these shaders will pass the new pre-commit git hooks. * Update any #pragma only_renderers that support ps4 to supporting both ps4 and ps5. * Add PS5 support for GraphicsDeviceType queries. * Add PS5 support for RuntimePlatform and BuildTarget * Switch to using separate PS4 and PS5 render pipeline. Docs, changelogs and remaining changes from the master PR. * Update minimum Unity editor version to 2019.4.23f1 to match the version that PlayStation 5 is added into the enums. * Update CHANGELOG.md * [VFX] Fixed Platform/dx12/vfx rwbuffer fix #3797 * Create ValidationExceptions.json * update screenshots * Create ValidationExceptions.json.meta * Update 8101_Opaque.png Co-authored-by: Sebastien Lagarde <[email protected]> Co-authored-by: Adrian1066 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
In Unity, compute buffers do not support typed buffers. Buffers are all created as structured ( with the exception of indirect arguements )
On some DX12 platforms, using RWBuffer in a shader causes a type mismatch and the shader is invalid.
Corrected the RWBuffer usage to RWStructuredBuffer
Testing status
Testing using the VFX URP/HDRP test suites
Comments to reviewers
Notes for the reviewers you have assigned.