Skip to content

Platform/dx12/vfx rwbuffer fix #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienlagarde merged 2 commits into from
Mar 9, 2021
Merged

Platform/dx12/vfx rwbuffer fix #3797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
372f61d
Use RWStructuredBuffer for strip data
Adrian1066 Mar 8, 2021
0a54beb
Update CHANGELOG.md
Adrian1066 Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.visualeffectgraph/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Remove some useless compilation triggers (modifying not connected or disabled nodes for instance)
- Tidy up of platform abstraction code for random number generation, requires a dependency on com.unity.render-pipelines.core for those abstractions.
- Fixed shader compilation errors with textures in shader graph [Case 1309219](https://issuetracker.unity3d.com/product/unity/issues/guid/1309219/)
- Fixed issue with VFX using incorrect buffer type for strip data

## [11.0.0] - 2020-10-21
### Added
Expand Down
2 changes: 1 addition & 1 deletion com.unity.visualeffectgraph/Shaders/UpdateStrips.compute
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ CBUFFER_START(params)
uint particlePerStripCount;
CBUFFER_END

RWBuffer<uint> stripDataBuffer;
RWStructuredBuffer<uint> stripDataBuffer;

#include "Packages/com.unity.visualeffectgraph/Shaders/VFXParticleStripCommon.hlsl"

Expand Down
2 changes: 1 addition & 1 deletion com.unity.visualeffectgraph/Shaders/VFXInit.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ ByteAddressBuffer inputAdditional;
#endif

#if HAS_STRIPS
RWBuffer<uint> stripDataBuffer;
RWStructuredBuffer<uint> stripDataBuffer;
#endif

${VFXPerPassInclude}
Expand Down
2 changes: 1 addition & 1 deletion com.unity.visualeffectgraph/Shaders/VFXUpdate.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RWStructuredBuffer<uint> indirectBuffer;
#endif

#if HAS_STRIPS
RWBuffer<uint> stripDataBuffer;
RWStructuredBuffer<uint> stripDataBuffer;
#endif

#if VFX_USE_STRIPALIVE_CURRENT
Expand Down