Skip to content

7.x.x Adds support for the PlayStation 5 platform #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebastienlagarde merged 14 commits into from
Mar 26, 2021
Merged

7.x.x Adds support for the PlayStation 5 platform #3690

sebastienlagarde merged 14 commits into from
Mar 26, 2021

Conversation

@robinb-u3d
Copy link
Contributor

@robinb-u3d robinb-u3d commented Mar 1, 2021

Purpose of this PR

This PR adds support for the PlayStation 5 platform to the SRP packages.

Testing status

  • Local testing - HDRP Template on both PS4 & PS5 and in the editor DX11.
  • Local testing - URP Template on both PS4 & PS5 and in the editor on DX11.

Comments to reviewers

Notes for the reviewers you have assigned.

@robinb-u3d
Update minimum Unity editor version to 2019.4.23f1 to match the versi…
221c1eb 
…on that PlayStation 5 is added into the enums.
@robinb-u3d
Copy link
Contributor Author

robinb-u3d commented Mar 15, 2021

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/7.x.x%252Fps5%252Fadd-ps5/.yamato%252F_abv.yml%2523all_project_ci_CUSTOM-REVISION/5795497/job/pipeline running against the latest 2019.4 staging version (4ab69048f7b8) has failed on:
HDRP on Win_DX11_Playmode_mono_Linear
VFX_HDRP on Win_DX11_Playmode_mono_Linear
VFX_HDRP on Win_DX11_Standalone_mono_Linear
Plus the minimum package version tests which make sense as 2019.5.23f1 is not yet published so we cannot yet get a valid version.

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/7.x.x%252Frelease/.yamato%252F_abv.yml%2523all_project_ci_CUSTOM-REVISION/5796839/job/pipeline
Running the same test with 7.x.x/release against the latest 2019.4 staging version 4ab69048f7b8) shows it also failing on the same three tests listed above.

@sebastienlagarde sebastienlagarde marked this pull request as ready for review March 15, 2021 16:33
@sebastienlagarde sebastienlagarde requested review from a team as code owners March 15, 2021 16:33
@robinb-u3d robinb-u3d requested a review from a team as a code owner March 26, 2021 08:02
@sebastienlagarde sebastienlagarde merged commit b9e8ac4 into 7.x.x/release Mar 26, 2021
@sebastienlagarde sebastienlagarde deleted the 7.x.x/ps5/add-ps5 branch March 26, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@theopnv theopnv theopnv approved these changes

@rthompson-unity rthompson-unity rthompson-unity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-7.x backported-10.x backported-2021.1 HDRP sdet Shader Graph SRP testing universal vfx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@robinb-u3d @sebastienlagarde @theopnv @rthompson-unity @Adrian1066