Fix Undo/Redo Stability for Light Temperature (1304176, 1301076) #3079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sebastien Lagarde <[email protected]>
* Not checking NdotL since it's not really valid for area lights (We have multiple valid light directions, not one) * Changelog Co-authored-by: sebastienlagarde <[email protected]>
#3035) Co-authored-by: sebastienlagarde <[email protected]>
* Fixed ShaderGraph decal draw order * Updated changelog Co-authored-by: sebastienlagarde <[email protected]>
* Fixed access to invalid Contexts references after exiting playmode. * Fixed comparison gizmo after playmode. * Fixes from PR feedback
… conserving specular color option for the specular input parametrization (similar to case 1257050) (#3060)
* adding a shadow mask test * Update reference images
sebastienlagarde
approved these changes
Jan 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Cases: 1304176, 1301076 (Duplicates)
This PR fixes the consistency of UI undo/redo behavior for light temperature.
It's a bit tough to convey the Undo/Redo keyboard action, but a gif included below attempting to demonstrate the corrected behavior:
Testing status
Confirmed the intended undo/redo behavior for light temperature, tested on single selection, multi selection, and changing the serialized value via the slider, float input field, and context menu.
Comments to reviewers
The issue happened due to always writing the slider output into the light temperature, when it should have only been done when the slider is changed (note, the other sliders already do this, which is why the undo/redo for them was already correct).