Skip to content

Commit 525ebf5

Browse files
johnparsJulienIgnace-UnitysebastienlagardeFrancescoC-unitypmavridis
authored
Fix Undo/Redo Stability for Light Temperature (1304176, 1301076) (#3079)
* Fixed Render Graph immediate mode. (#3033) Co-authored-by: Sebastien Lagarde <[email protected]> * Fix issue with shadow mask and area lights (#3019) * Not checking NdotL since it's not really valid for area lights (We have multiple valid light directions, not one) * Changelog Co-authored-by: sebastienlagarde <[email protected]> * Fix issue with capture callback (now includes post processing results) (#3035) Co-authored-by: sebastienlagarde <[email protected]> * [HDRP] Fix decal draw order for ShaderGraph decal materials (#3018) * Fixed ShaderGraph decal draw order * Updated changelog Co-authored-by: sebastienlagarde <[email protected]> * Fixed various Look Dev issues after exiting Playmode (#2956) * Fixed access to invalid Contexts references after exiting playmode. * Fixed comparison gizmo after playmode. * Fixes from PR feedback * StackLit: Fix SG surface option property block to only display energy conserving specular color option for the specular input parametrization (similar to case 1257050) (#3060) * Fixed missing BeginCameraRendering call for custom render mode of a Camera (#3063) * Implement custom drawer for layer mask parameters (#3066) * Adding mixed light baking shadowmask test (#3052) * adding a shadow mask test * Update reference images * Apply the fix * Changelog * Update CHANGELOG.md * fix merge issue Co-authored-by: JulienIgnace-Unity <[email protected]> Co-authored-by: Sebastien Lagarde <[email protected]> Co-authored-by: FrancescoC-unity <[email protected]> Co-authored-by: Pavlos Mavridis <[email protected]> Co-authored-by: Antoine Lelievre <[email protected]> Co-authored-by: slunity <[email protected]> Co-authored-by: Adrien de Tocqueville <[email protected]> Co-authored-by: Rémi Chapelain <[email protected]>
1 parent 9581f38 commit 525ebf5

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

com.unity.render-pipelines.high-definition/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
1111
- Fixed XR depth copy when using MSAA.
1212
- Fixed after post process custom pass scale issue when dynamic resolution is enabled (case 1299194).
1313
- Fixed an issue with light intensity prefab override application not visible in the inspector (case 1299563).
14+
- Fixed Undo/Redo instability of light temperature.
1415

1516
### Changed
1617
- Change the source value for the ray tracing frame index iterator from m_FrameCount to the camera frame count (case 1301356).

com.unity.render-pipelines.high-definition/Editor/Lighting/LightUnit/LightUnitSlider.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -569,12 +569,14 @@ void SliderWithTextureNoTextField(Rect rect, ref float value, Vector2 range, Lig
569569
// Draw the exponential slider that fits 6500K to the white point on the gradient texture.
570570
var internalValue = GUI.HorizontalSlider(rect, ValueToSlider(value), 0f, 1f, SliderStyles.k_TemperatureBorder, SliderStyles.k_TemperatureThumb);
571571

572-
// Map the value back into kelvin.
573-
value = SliderToValue(internalValue);
574-
575572
// Round to nearest since so much precision is not necessary for kelvin while sliding.
576573
if (EditorGUI.EndChangeCheck())
574+
{
575+
// Map the value back into kelvin.
576+
value = SliderToValue(internalValue);
577+
577578
value = Mathf.Round(value);
579+
}
578580
}
579581
}
580582

0 commit comments

Comments
 (0)