[HDRP] Fix decal draw order for ShaderGraph decal materials #3018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmavridis
approved these changes
Jan 7, 2021
sebastienlagarde
approved these changes
Jan 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Source issue: https://forum.unity.com/threads/draw-order-does-not-work-for-decals-made-with-the-shader-graph.1017283/
And: https://fogbugz.unity3d.com/f/cases/1301137/
Decal Draw Order was always returning 0 for ShaderGraph decals because the ShaderGraph decal shader doesn't have the
_Unity_Identify_HDRP_Decalproperty.Adding this specific property is not a correct fix so I opted for a simple check if the order property exists or not before returning the actual draw order value.
Testing status
Played a bit with the Draw Order property in a decal material created with ShaderGraph:
DecalOrder.mp4
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/hd%252Ffix%252Fshader-graph-decal-draw-order/.yamato%252Fall-hdrp.yml%2523PR_HDRP_CUSTOM-REVISION/4794954/job