Conversation
…on tests Agent-Logs-Url: https://github.com/Tyrrrz/GitHubActionsTestLogger/sessions/d5137236-5f84-47a5-bdba-80abe55513dd Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Tyrrrz/GitHubActionsTestLogger/sessions/d5137236-5f84-47a5-bdba-80abe55513dd Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prime #76 +/- ##
=======================================
Coverage 85.22% 85.22%
=======================================
Files 19 19
Lines 758 758
Branches 85 85
=======================================
Hits 646 646
Misses 59 59
Partials 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Windows-only failures in the “nearly full summary file” truncation tests by ensuring the summary file’s write handle is closed before attempting to reopen the same file for reading.
Changes:
- Explicitly disposes the file-backed
summaryWriterafterFlushAsync()and before reading bytes from the summary file in the VsTest truncation test. - Applies the same disposal fix to the MTP truncation test variant.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| GitHubActionsTestLogger.Tests/VsTestSummarySpecs.cs | Disposes the file-backed summary writer before reading the summary file to avoid sharing conflicts on Windows. |
| GitHubActionsTestLogger.Tests/MtpSummarySpecs.cs | Mirrors the same early-dispose behavior for the MTP variant of the truncation test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
summaryWriter before reading file in truncation tests
This was referenced May 2, 2026
Open
This was referenced May 5, 2026
github-actions Bot
pushed a commit
to saan800/github
that referenced
this pull request
May 6, 2026
…#249) Updated [GitHubActionsTestLogger](https://github.com/Tyrrrz/GitHubActionsTestLogger) from 3.0.2 to 3.0.4. <details> <summary>Release notes</summary> _Sourced from [GitHubActionsTestLogger's releases](https://github.com/Tyrrrz/GitHubActionsTestLogger/releases)._ ## 3.0.4 <!-- Release notes generated using configuration in .github/release.yml at 3.0.4 --> ## What's Changed ### Enhancements * Add PowerKit (prerelease), update PolyShim and CSharpier, remove duplicate utilities by @Copilot in Tyrrrz/GitHubActionsTestLogger#72 ### Bugs * Explicitly dispose `summaryWriter` before reading file in truncation tests by @Copilot in Tyrrrz/GitHubActionsTestLogger#76 * Fix GITHUB_STEP_SUMMARY size limit exceeded with non-ASCII characters by @Copilot in Tyrrrz/GitHubActionsTestLogger#75 **Full Changelog**: Tyrrrz/GitHubActionsTestLogger@3.0.3...3.0.4 ## 3.0.3 ## What's Changed * Truncate or omit step summary when approaching GitHub's 1 MiB limit by @Copilot in Tyrrrz/GitHubActionsTestLogger#68 * Pin Microsoft.Testing.Platform reference to 2.0.0 by @Copilot in Tyrrrz/GitHubActionsTestLogger#70 **Full Changelog**: Tyrrrz/GitHubActionsTestLogger@3.0.2...3.0.3 Commits viewable in [compare view](Tyrrrz/GitHubActionsTestLogger@3.0.2...3.0.4). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the "nearly full summary file" truncation tests, the
summaryWriter(backed by a file stream opened for writing) was left open whenFile.ReadAllByteswas called. On Windows, opening a second handle for reading conflicts with the existing write handle, causing the test to fail.The fix adds an explicit
await summaryWriter.DisposeAsync()call immediately afterFlushAsync()and before the file read in both affected tests:VsTestSummarySpecs.cs—I_can_try_to_use_the_logger_to_produce_a_summary_when_the_output_file_is_nearly_full_and_get_a_truncated_summaryMtpSummarySpecs.cs— same test in the MTP variantClosing the write handle first means
File.ReadAllBytescan always open the file for reading without a sharing-mode conflict, on both Windows and Linux.