Conversation
…tilities Agent-Logs-Url: https://github.com/Tyrrrz/GitHubActionsTestLogger/sessions/09f0fdea-79d4-4cb6-975f-04c04f60547f Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
|
@copilot why are TempFile/TempDir not replaced? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prime #72 +/- ##
==========================================
+ Coverage 84.56% 85.22% +0.65%
==========================================
Files 23 19 -4
Lines 784 758 -26
Branches 92 85 -7
==========================================
- Hits 663 646 -17
+ Misses 63 59 -4
+ Partials 58 53 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR replaces several in-repo utility/extension implementations with equivalents provided by the new PowerKit source package, updates a couple of tooling/runtime dependencies, and applies reformatting.
Changes:
- Add
PowerKit(0.0.0-a.4) and migrate call sites toPowerKit.Extensions. - Update
PolyShimto 2.9.0 andCSharpier.MsBuildto 1.2.6 (via central package management). - Remove now-duplicated extension utility files and reformat affected files.
Reviewed changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| GitHubActionsTestLogger/VsTestLogger.cs | Import PowerKit.Extensions for extension method usage. |
| GitHubActionsTestLogger/Utils/StackFrame.cs | Switch extension-method dependency to PowerKit.Extensions (e.g., parsing helpers). |
| GitHubActionsTestLogger/Utils/Extensions/VsTestExtensions.cs | Import PowerKit.Extensions for string helpers used in VSTest extensions. |
| GitHubActionsTestLogger/Utils/Extensions/MtpExtensions.cs | Import PowerKit.Extensions for shared helpers used by MTP extensions. |
| GitHubActionsTestLogger/Utils/Extensions/StringExtensions.cs | Removed (replaced by PowerKit string/StringBuilder extensions). |
| GitHubActionsTestLogger/Utils/Extensions/ParsingExtensions.cs | Removed (replaced by PowerKit int parsing extensions). |
| GitHubActionsTestLogger/Utils/Extensions/GenericExtensions.cs | Removed (replaced by PowerKit functional extensions such as Pipe). |
| GitHubActionsTestLogger/Utils/Extensions/AssemblyExtensions.cs | Removed (replaced by PowerKit assembly extensions). |
| GitHubActionsTestLogger/Reporting/TestSummaryTemplate.cshtml | Add @using PowerKit.Extensions for extension methods used in the template. |
| GitHubActionsTestLogger/Reporting/TestReportingContext.cs | Import PowerKit.Extensions for StringBuilder extension usage. |
| GitHubActionsTestLogger/MtpLoggerOptionsProvider.cs | Import PowerKit.Extensions for migrated extension methods. |
| GitHubActionsTestLogger/MtpLogger.cs | Import PowerKit.Extensions for migrated extension methods. |
| GitHubActionsTestLogger/GitHubActionsTestLogger.csproj | Add PowerKit package reference. |
| GitHubActionsTestLogger/GitHub/GitHubWorkflow.cs | Use PowerKit.Extensions and formatting adjustments. |
| GitHubActionsTestLogger/GitHub/GitHubEnvironment.cs | Use PowerKit.Extensions for helper chaining. |
| GitHubActionsTestLogger.Tests/Utils/TempFile.cs | Formatting-only change. |
| GitHubActionsTestLogger.Tests/Utils/TempDir.cs | Formatting-only change. |
| Directory.Packages.props | Central version updates for CSharpier/PolyShim and add PowerKit version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/Tyrrrz/GitHubActionsTestLogger/sessions/8c0e612a-534f-4e66-b6b0-b0b90c01f45f Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
|
@copilot look for more utilities that can be removed in all projects |
…ensions Agent-Logs-Url: https://github.com/Tyrrrz/GitHubActionsTestLogger/sessions/e67f4302-4800-47a1-a38b-112ff87c6d6c Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Audited all remaining local utilities across both projects against PowerKit's content files. One more removal was possible:
Kept (no PowerKit equivalent):
|
Replaces several locally-implemented utility/extension classes with their equivalents from PowerKit 0.0.0-a.4, a source package providing the same primitives. Also bumps PolyShim to 2.9.0 and CSharpier.MsBuild to 1.2.6, then reformats.
Removed (now provided by PowerKit)
Main project:
Utils/Extensions/AssemblyExtensions.cs→PowerKit.Extensions.AssemblyExtensionsUtils/Extensions/StringExtensions.cs→PowerKit.Extensions.StringExtensions+StringBuilderExtensionsUtils/Extensions/GenericExtensions.cs→PowerKit.Extensions.FunctionalExtensionsUtils/Extensions/ParsingExtensions.cs→PowerKit.Extensions.IntExtensionsTest project:
Tests/Utils/TempFile.cs→PowerKit.TempFileTests/Utils/TempDir.cs→PowerKit.TempDirectoryTests/Utils/Extensions/FileExtensions.cs→PowerKit.Extensions.FileExtensionsKept (not covered by PowerKit):
TimeSpanExtensions(ToHumanString),ExceptionExtensions(ReplaceStackTrace),MtpExtensions,VsTestExtensions,ContentionTolerantWriteFileStream,StackFrame.Package changes
Namespace updates
Call sites that used the deleted extension classes now import
PowerKit.Extensionsinstead of (or alongside)GitHubActionsTestLogger.Utils.Extensions. Test files now importPowerKitforTempFileandTempDirectory, andPowerKit.Extensionsfor file utilities.