Skip to content

Explicitly dispose summaryWriter before reading file in truncation tests #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyrrrz merged 2 commits into from
May 1, 2026
Merged

Explicitly dispose summaryWriter before reading file in truncation tests #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
414e8be
fix: explicitly dispose summaryWriter before reading file in truncati…
Copilot May 1, 2026
6d846bc
fix: use DisposeAsync consistently in VsTestSummarySpecs.cs
Copilot May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions GitHubActionsTestLogger.Tests/MtpSummarySpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ public async Task I_can_try_to_use_the_logger_to_produce_a_summary_when_the_outp
await app.RunAsync();

await summaryWriter.FlushAsync();
await summaryWriter.DisposeAsync();
Comment thread
Tyrrrz marked this conversation as resolved.

// Assert
var commandOutput = commandWriter.ToString();
Expand Down
1 change: 1 addition & 0 deletions GitHubActionsTestLogger.Tests/VsTestSummarySpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,7 @@ public async Task I_can_try_to_use_the_logger_to_produce_a_summary_when_the_outp
);

await summaryWriter.FlushAsync();
await summaryWriter.DisposeAsync();
Comment thread
Tyrrrz marked this conversation as resolved.

// Assert
var commandOutput = commandWriter.ToString();
Expand Down