Fix build errors from obsolete MTP API usage#64
Merged
Conversation
…18 for CancelledTestNodeStateProperty Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix build errors and add ignores for obsolete issues
Fix build errors from obsolete MTP API usage
Mar 1, 2026
Tyrrrz
added
bug
Tyrrrz
reviewed
Mar 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 84.42% 84.62% +0.20%
==========================================
Files 23 23
Lines 719 722 +3
Branches 85 85
==========================================
+ Hits 607 611 +4
Misses 58 58
+ Partials 54 53 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions Test Logger’s Microsoft.Testing.Platform (MTP) integration to compile cleanly against MTP 2.1.0 with TreatWarningsAsErrors=true, addressing newly-obsoleted APIs.
Changes:
- Replaced obsolete
AddTestSessionLifetimeHandlewithAddTestSessionLifetimeHandlerfor MTP 2.1.0 compatibility. - Scoped suppression of CS0618 around
CancelledTestNodeStatePropertyhandling to preserve backward compatibility without failing the build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
GitHubActionsTestLogger/MtpIntegration.cs |
Updates MTP test host registration to use the non-obsolete lifetime handler API. |
GitHubActionsTestLogger/MtpLogger.cs |
Adds a narrowly-scoped pragma to suppress obsolete warning for cancelled test node state mapping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
|
@copilot please fix formatting errors |
Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Contributor
Author
This was referenced Mar 25, 2026
This was referenced Mar 25, 2026
Open
github-actions bot
pushed a commit
to IntelliTect/EssentialCSharp.ListingManager
that referenced
this pull request
Mar 26, 2026
Updated [GitHubActionsTestLogger](https://github.com/Tyrrrz/GitHubActionsTestLogger) from 3.0.1 to 3.0.2. <details> <summary>Release notes</summary> _Sourced from [GitHubActionsTestLogger's releases](https://github.com/Tyrrrz/GitHubActionsTestLogger/releases)._ ## 3.0.2 ## What's Changed * Bump the nuget group with 4 updates by @dependabot[bot] in Tyrrrz/GitHubActionsTestLogger#59 * Bump the nuget group with 1 update by @dependabot[bot] in Tyrrrz/GitHubActionsTestLogger#60 * Migrate to Centralized NuGet Package Management (CPM) by @Copilot in Tyrrrz/GitHubActionsTestLogger#61 * Use range indexer in `SubstringAfterLast` by @Copilot in Tyrrrz/GitHubActionsTestLogger#62 * Bump the nuget group with 7 updates by @dependabot[bot] in Tyrrrz/GitHubActionsTestLogger#63 * Fix build errors from obsolete MTP API usage by @Copilot in Tyrrrz/GitHubActionsTestLogger#64 * Remove explicit Microsoft.SourceLink.GitHub package reference by @Copilot in Tyrrrz/GitHubActionsTestLogger#65 * Add strong naming by @mgravell in Tyrrrz/GitHubActionsTestLogger#67 ## New Contributors * @Copilot made their first contribution in Tyrrrz/GitHubActionsTestLogger#61 * @mgravell made their first contribution in Tyrrrz/GitHubActionsTestLogger#67 **Full Changelog**: Tyrrrz/GitHubActionsTestLogger@3.0.1...3.0.2 Commits viewable in [compare view](Tyrrrz/GitHubActionsTestLogger@3.0.1...3.0.2). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddTestSessionLifetimeHandlewithAddTestSessionLifetimeHandlerinMtpIntegration.cs#pragma warning disable CS0618aroundCancelledTestNodeStatePropertyusage inMtpLogger.cs💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.