Skip to content

Add strong naming#67

Merged
Tyrrrz merged 1 commit intoTyrrrz:primefrom
mgravell:marc/strong-name
Mar 25, 2026
Merged

Add strong naming#67
Tyrrrz merged 1 commit intoTyrrrz:primefrom
mgravell:marc/strong-name

Conversation

@mgravell
Copy link
Contributor

Closes #66

  • create new snk for the project (sn -k)
  • (global build) specify the snk
  • (main assembly build) enable strong-name-signing

Main tests are green in Rider; secondary tests have some failure with/without the changes 🤷

- create new snk for the project (`sn -k`)
- (global build) specify the snk
- (main assembly build) enable strong-name-signing
@Tyrrrz Tyrrrz added the enhancement New feature or request label Mar 25, 2026
@Tyrrrz Tyrrrz changed the title Propose strong-naming of the main dll Add strong-naming Mar 25, 2026
@Tyrrrz Tyrrrz changed the title Add strong-naming Add strong naming Mar 25, 2026
@Tyrrrz
Copy link
Owner

Tyrrrz commented Mar 25, 2026

Thanks!

secondary tests have some failure with/without the changes 🤷

Those are demo tests that are meant to fail. They are excluded from dotnet test, but Rider runs them anyway by default.

@Tyrrrz Tyrrrz merged commit 3da2169 into Tyrrrz:prime Mar 25, 2026
7 checks passed
@mgravell
Copy link
Contributor Author

mgravell commented Mar 25, 2026

fix verified as successful (here), cheers

@mgravell mgravell deleted the marc/strong-name branch March 25, 2026 11:56
This was referenced Mar 25, 2026
This was referenced Mar 25, 2026
github-actions bot pushed a commit to IntelliTect/EssentialCSharp.ListingManager that referenced this pull request Mar 26, 2026
Updated
[GitHubActionsTestLogger](https://github.com/Tyrrrz/GitHubActionsTestLogger)
from 3.0.1 to 3.0.2.

<details>
<summary>Release notes</summary>

_Sourced from [GitHubActionsTestLogger's
releases](https://github.com/Tyrrrz/GitHubActionsTestLogger/releases)._

## 3.0.2

## What's Changed
* Bump the nuget group with 4 updates by @​dependabot[bot] in
Tyrrrz/GitHubActionsTestLogger#59
* Bump the nuget group with 1 update by @​dependabot[bot] in
Tyrrrz/GitHubActionsTestLogger#60
* Migrate to Centralized NuGet Package Management (CPM) by @​Copilot in
Tyrrrz/GitHubActionsTestLogger#61
* Use range indexer in `SubstringAfterLast` by @​Copilot in
Tyrrrz/GitHubActionsTestLogger#62
* Bump the nuget group with 7 updates by @​dependabot[bot] in
Tyrrrz/GitHubActionsTestLogger#63
* Fix build errors from obsolete MTP API usage by @​Copilot in
Tyrrrz/GitHubActionsTestLogger#64
* Remove explicit Microsoft.SourceLink.GitHub package reference by
@​Copilot in Tyrrrz/GitHubActionsTestLogger#65
* Add strong naming by @​mgravell in
Tyrrrz/GitHubActionsTestLogger#67

## New Contributors
* @​Copilot made their first contribution in
Tyrrrz/GitHubActionsTestLogger#61
* @​mgravell made their first contribution in
Tyrrrz/GitHubActionsTestLogger#67

**Full Changelog**:
Tyrrrz/GitHubActionsTestLogger@3.0.1...3.0.2

Commits viewable in [compare
view](Tyrrrz/GitHubActionsTestLogger@3.0.1...3.0.2).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=GitHubActionsTestLogger&package-manager=nuget&previous-version=3.0.1&new-version=3.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing dev-dependency flag breaks usage with strong-named packages

2 participants