Skip to content

Fix build errors from obsolete MTP API usage #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyrrrz merged 5 commits into from
Mar 1, 2026
Merged

Fix build errors from obsolete MTP API usage #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f95f819
Initial plan
Copilot Mar 1, 2026
d2ce095
Fix build errors: use AddTestSessionLifetimeHandler and suppress CS06…
Copilot Mar 1, 2026
0cac196
Apply suggestion from @Tyrrrz
Tyrrrz Mar 1, 2026
988cff3
Update GitHubActionsTestLogger/MtpLogger.cs
Tyrrrz Mar 1, 2026
1cde2da
Fix formatting: indent comment to match surrounding switch arms
Copilot Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GitHubActionsTestLogger/MtpIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void AddGitHubActionsReporting(TextWriter commandWriter, TextWriter summa
);

testApplicationBuilder.TestHost.AddDataConsumer(compositeExtension);
testApplicationBuilder.TestHost.AddTestSessionLifetimeHandle(compositeExtension);
testApplicationBuilder.TestHost.AddTestSessionLifetimeHandler(compositeExtension);

testApplicationBuilder.CommandLine.AddProvider(() => new MtpLoggerOptionsProvider());
}
Expand Down
3 changes: 3 additions & 0 deletions GitHubActionsTestLogger/MtpLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,10 @@ CancellationToken cancellationToken
ErrorTestNodeStateProperty => TestOutcome.Failed,
TimeoutTestNodeStateProperty => TestOutcome.Failed,
SkippedTestNodeStateProperty => TestOutcome.Skipped,
// Backwards compatibility with frameworks that still emit this property
#pragma warning disable CS0618
CancelledTestNodeStateProperty => TestOutcome.Skipped,
#pragma warning restore CS0618
_ => TestOutcome.None,
},
state.Explanation ?? exception?.Message,
Expand Down