-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove csrc from the RTPHeader struct. #750
Conversation
Why not make gtest an optional dependency and make this test an optional in cmake? |
removal don't know about the tests Review status: 0 of 7 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 2 of 7 files at r1. Comments from Reviewable |
Added gtest to cmake. Not running it on travis. |
Could we not make C++ compiler required for building toxcore without having a very good reason for this? :\ |
It's not required for compiling it, but maybe for compiling its tests. |
(some of the tests). |
It does make sense for the monolith test, but not much for others. Why is |
Why C++ and gtest: it's much easier to write unit tests with it. libcheck is not much more than a glorified printf debugging library. Comparing values, printing them, etc. is spartanic. I'm not going to write more tests with libcheck, I'd rather get rid of it altogether. Given the opposition, I've removed it from cmake again. |
4b0c356
to
84410f2
Compare
This is not used by anything in the code, so we shouldn't have it in the header.
This is not used by anything in the code, so we shouldn't have it in the
header.
This change is