Improve stability of crypto_memcmp test. #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
memcmp-test
branch
9 times, most recently
from
aa2268f
to
0c21e4d
Compare
Also reduce number of people in conference to 5, because on Circle CI the test times out trying to connect more than 6 or 7 people. The persistent conferences PR will improve this so we can set it much higher then.
|
Reviewed 9 of 9 files at r1. Comments from Reviewable |
|
Reviewed 9 of 9 files at r1. CMakeLists.txt, line 436 at r1 (raw file):
Why do we compile this ourselves? Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. CMakeLists.txt, line 436 at r1 (raw file): Previously, robinlinden (Robin Lindén) wrote…
GTest doesn't come with a precompiled library. This means it's so easy to compile we can even do it on appveyor :). Comments from Reviewable |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is