-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove libcheck from the dependencies. #766
Conversation
9f753e8
to
0e4e97e
Compare
Wow, libcheck looks kind of useless after reading this PR. Review status: 0 of 28 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
What libcheck does behind the scenes:
That's it. |
072e21c
to
d21fa8f
Compare
I'm running a travis build with all the "if:"s commented out, so we can see if this works on all the builds. |
4c48dc2
to
f70fc79
Compare
https://travis-ci.org/TokTok/c-toxcore/builds/338134142 - it works on all builds. |
ecc33ad
to
f8a6411
Compare
(the check removal. Haven't reviewed the crypto_memcmp test commit.) Reviewed 27 of 27 files at r2. CMakeLists.txt, line 224 at r2 (raw file):
Where did this come from? Comments from Reviewable |
Reviewed 8 of 8 files at r1. Comments from Reviewable |
4f23fe8
to
3f6d1e5
Compare
28c7b82
to
7ff713e
Compare
We're not gaining much from this library, and it's a burden, especially for windows development.
We're not gaining much from this library, and it's a burden, especially
for windows development.
This change is