Merged
Conversation
fix comment url
set soundcloud default kiosk
fix empty author name
and fallback to avatar thumbnail if track thumbnail isn't found
(in the youtube subscription extractor) Ignore subscriptions that have an empty title instead of throwing an error: the youtube subscription_manager XML file can sometimes contain those (i.e. deleted channels).
(youtube subscription extractor)
if a channel if deleted (thus it has an empty title), it is imported in NewPipe anyway, so that if it becomes undeleted in the future, it will be shown in the app.
Also modified the test for empty title, since now subscriptions with empty title are not ignored anymore.
If ever YouTube changes thing again (or uses old urls for some unknown reason), this prevents the extractor from crashing. As suggested here: https://github.com/TeamNewPipe/NewPipeExtractor/pull/163/files/133cc032d9987130927e4c00e78e9fdbca1331dd#r283529811
Fix invalid yt url: signature tag name is not always "signature"
The comment function has been disabled for the video on which we ran the test. We are testing the comments of a different video now.
Fixed youtube subscription import: ignore ones with invalid url and keep ones with empty title.
Fix failing YouTube comments tests
soundcloud parsing helper: fixed id parser regex
Fix SoundCloud playlists parsing exception
Improve thumbnail quality for Soundcloud service
update gradle to version 5.1 fix sts issue for agegated videos GOD DAMN FUCKING BULLSHIT add duratin for controversal/age gated videos bring back sts remove ignores fix ogg test
fix duration can not be paresd
This was referenced Jul 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will move on to version 0.17.0.