Conversation
Sanitize youtube comment
fix npe in fetching service by url
1 task
Contributor
Author
|
I have been raising PRs for master branch till now. Should we switch to dev branch in the extractor also? |
Member
|
Yes |
Contributor
Author
|
I have changed the base branch to dev now. This PR also includes a couple of other changes that were merged to master but not dev. |
Member
|
Is dev and master not up to date? |
Contributor
Author
No. master is 5 commits ahead of dev. This PR will fix that though. |
Member
|
Ok |
theScrabi
approved these changes
Mar 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required for TeamNewPipe/NewPipe#2168