Skip to content

Fix invalid yt url: signature tag name is not always "signature" #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TobiGr merged 2 commits into from
May 14, 2019
Merged

Fix invalid yt url: signature tag name is not always "signature" #163

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
133cc03
Fix invalid yt url: signature tag name is not always "signature"
Stypox May 13, 2019
c70d285
Add fallback for urls not conaining the "sp" tag
Stypox May 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ private Map<String, ItagItem> getItags(String encodedUrlMapKey, ItagItem.ItagTyp
String streamUrl = tags.get("url");
// if video has a signature: decrypt it and add it to the url
if (tags.get("s") != null) {
streamUrl = streamUrl + "&signature=" + decryptSignature(tags.get("s"), decryptionCode);
streamUrl = streamUrl + "&" + tags.get("sp") + "=" + decryptSignature(tags.get("s"), decryptionCode);

@TobiGr TobiGr May 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd like to include this into 0.16.2 so we can get this fix out asap. Can we ensure that tags.get("sp") != null? If this is the case, we are good to go. Otherwise, I'd suggest to use streamUrl = streamUrl + "&signature=" + decryptSignature(tags.get("s"), decryptionCode); as fallback if tags.get("sp") == null.

@Stypox Stypox May 14, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll implement and test it this evening

}
urlAndItags.put(streamUrl, itagItem);
}
Expand Down