Skip to content

Conversation

@blackwang08
Copy link

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Because In some cases, the original way of creating Alterdialog will make the text of the button become the same color of the background so it seems to be invisible. To solve this question, I set the color of the text of the button different from background(In light mode it is black, in dark and black mode it is white) to avoid this problem.

Before/After Screenshots/Screen Record

  • Before:
before.mp4
  • After:
after3mode.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@blackwang08 blackwang08 mentioned this pull request Apr 29, 2022
5 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This seems the correct thing to do, though I would like @litetex to confirm

@blackwang08
Copy link
Author

thanks for your reply!

Thank you! This seems the correct thing to do, though I would like @litetex to confirm

@opusforlife2 opusforlife2 requested a review from litetex May 2, 2022 18:25
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

The underlying problem - which is not addressed here but in #8332 - is that the RouterActivity is not implemented correctly (it e.g. set's colorPrimary to transparent) which causes multiple problems.

This can be closed in favor of #8332 - a fix is better than a workaround.

@triallax triallax added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels May 22, 2022
@litetex
Copy link
Member

litetex commented May 22, 2022

Superseded by #8332 and #8340

@litetex litetex closed this May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug GUI Issue is related to the graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download popup file already exists action buttons display issue

4 participants