Skip to content

first commit#8299

Closed
blackwang08 wants to merge 1 commit intoTeamNewPipe:devfrom
blackwang08:dev
Closed

first commit#8299
blackwang08 wants to merge 1 commit intoTeamNewPipe:devfrom
blackwang08:dev

Conversation

@blackwang08
Copy link

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Because In some cases, the original way of creating Alterdialog will make the text of the button become white so it seems to be invisible. To solve this question, I force the text of the button become black to avoid this problem.

Before/After Screenshots/Screen Record

  • Before:
before.mp4
  • After:
after.mp4

Fixes the following issue(s)

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex
Copy link
Member

litetex commented Apr 27, 2022

This PR has multiple problems:

  1. You didn't read the contribution guidelines
    • The branch-name, commit and PR title are not meaningful
  2. The PR does not fix the problem: NewPipe has a dark mode; black text on dark background is not a good idea
    We also use styles and themes for styling and not hardcoded values.
    You may consider reading https://developer.android.com/guide/topics/ui/look-and-feel/themes

@litetex litetex closed this Apr 27, 2022
@blackwang08 blackwang08 deleted the dev branch April 29, 2022 07:25
@blackwang08
Copy link
Author

I have change the way to fix this question using styles and themes instead of hardcoded values, and some mistake in pull request format. new pull request have fix this question in three color mode.

@blackwang08
Copy link
Author

I'm very sorry for the inconvenience

@blackwang08
Copy link
Author

here is the new pull request. #8305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download popup file already exists action buttons display issue

2 participants