Skip to content

fix button cannot be seen when download popup file already exists #8305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blackwang08 wants to merge 2 commits into from
Closed

fix button cannot be seen when download popup file already exists #8305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02afd9a
first commit
blackwang08 Apr 27, 2022
ca16e07
fix button cannot be seen when download popup file already exists
blackwang08 Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/src/main/java/org/schabi/newpipe/download/DownloadDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,6 @@ private void checkSelectedDownload(final StoredDirectoryHelper mainStorage,
final Uri targetFile, final String filename,
final String mime) {
StoredFileHelper storage;

try {
if (mainStorage == null) {
// using SAF on older android version
Expand Down Expand Up @@ -931,7 +930,6 @@ private void checkSelectedDownload(final StoredDirectoryHelper mainStorage,
break;
}
});

askDialog.create().show();
}

Expand Down
3 changes: 3 additions & 0 deletions app/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
<item name="android:windowBackground">@color/light_background_color</item>
<item name="windowBackground">@color/light_background_color</item>

<item name="android:textColor">@color/light_youtube_accent_color</item>
<item name="separator_color">@color/light_separator_color</item>
<item name="contrast_background_color">@color/light_contrast_background_color</item>
<item name="checked_selector">@drawable/selector_checked_light</item>
Expand All @@ -52,6 +53,7 @@
<item name="android:windowBackground">@color/dark_background_color</item>
<item name="windowBackground">@color/dark_background_color</item>

<item name="android:textColor">@color/dark_youtube_accent_color</item>
<item name="separator_color">@color/dark_separator_color</item>
<item name="contrast_background_color">@color/dark_contrast_background_color</item>
<item name="checked_selector">@drawable/selector_checked_dark</item>
Expand All @@ -73,6 +75,7 @@
<item name="android:windowBackground">@color/black_background_color</item>
<item name="windowBackground">@color/black_background_color</item>

<item name="android:textColor">@color/dark_youtube_accent_color</item>
<item name="separator_color">@color/black_separator_color</item>
<item name="contrast_background_color">@color/black_contrast_background_color</item>

Expand Down