Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CMD-97 isolate breadcrumbs from content #870

Merged
merged 36 commits into from
Sep 13, 2024
Merged

feat: CMD-97 isolate breadcrumbs from content #870

merged 36 commits into from
Sep 13, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 12, 2024 •
edited
Loading

Overview

Allow News to be served without breadcrumbs and container.

How?
  • Isolate breadcrumbs from content.
  • Distinguish CMS content from app content.
Why?

Related

Changes

  • moved breadcrumbs from block "content" to new block "breadcrumbs"

Testing

  1. Verify a "Standard"-template Blog page still has breadcrumbs.
  2. Verify a "Fullwidth"-template Blog page now does not have breadcrumbs.
  3. Verify a "Standard"-template CMS page still has breadcrumbs.
  4. Verify a "Fullwidth"-template CMS page now does not have breadcrumbs.

UI

CMS Pages

Standard Full Width
870 - Standard 870 - Fullwidth

App Pages e.g. Blog

Standard Full Width
870 - Standard - News 870 - Fullwidth - News

wesleyboar and others added 30 commits July 19, 2024 15:54
@wesleyboar
refactor: CMD-97 breadcrumbs for news via 1 template
17640a4
@wesleyboar
idea: TUP-706 4.a.i change RSS feed render ⚠️
55dc431 
NOT WORKING! Fails with:

> NoReverseMatch at /feed/
> '' is not a registered namespace
@wesleyboar
refactor: TUP-706 rename and document blog block
de81256
@wesleyboar
feat: TUP-706 render page with only (*_)content
463871f
@wesleyboar
fix: TUP-706 disable failed djangocms_blog_c… url
8038de7
@wesleyboar
idea!: TUP-706 render blog base via custom app
89a160c 
Fails, because it renders nothing.
@wesleyboar
feat!: TUP-706 render remote url content
db234df 
Load `/blog/remote`.

BREAKING CHANGE: Changed `/blog` to `/blog/local`
@wesleyboar
chore: TUP-706 move an import higher in file
d7f10ae
@wesleyboar
feat: TUP-706 render remote url via setting
ec10c85
@wesleyboar
fix: TUP-706 render blog customizations
223b72a
@wesleyboar
Merge branch 'main' into feat/tup-706-news-on-other-sites
aaa971e
@wesleyboar
fix: TUP-706 render feed ⚠️
646b26d 
⚠️ Does NOT render feed items.
@wesleyboar
docs: TUP-706 describe each URL's problem
aa709fd
@wesleyboar
docs: TUP-706 describe each URL goal and status
26a9412
@wesleyboar
feat: TUP-706 A.1+3.c remote markup via template
4e78038
@wesleyboar
Merge branch 'main' into feat/tup-706-news-on-other-sites
17380fb
@wesleyboar
feat: TUP-706 A.1.a. support BLOG_MULTISITE
a461693
@wesleyboar
fix: TUP-706 A.1.a. cannot login to site 2
6bece39
@wesleyboar
Revert "fix: TUP-706 A.1.a. cannot login to site 2"
e6bdbbf 
This reverts commit 6bece39.

This did not fix anything. `SESSION_COOKIE_SECURE=False` is still required locally.
@wesleyboar
Merge branch 'main' into feat/tup-706-news-on-other-sites
4f9888b
@wesleyboar
docs: TUP-706 feed status (ineffectual)
104fe71
@wesleyboar
docs: tup-706 urls for local and remote
dfc9fa4
@wesleyboar
feat(poc): TUP-706 get news from remote url
cd59bf9 
Messy but functional!
@wesleyboar
chore: remove test print statements from feeds
6995c44
@wesleyboar
core: clean up views
db79397
@wesleyboar
core: clean up views more
a6d8551
@wesleyboar
refactor: switch order of methods in view class
82027fe
@wesleyboar
feat: TUP-706 edit links via get_client_markup()
0c94401
@wesleyboar
fix: TUP-706 broken links
49edd04 
- ✓ fix links to articles
- ✓ fix pagination links
@wesleyboar
chore: remove tup-706 work / isolate CMD-97 work
f1dc83c
@wesleyboar wesleyboar changed the title feat: isolate breadcrumbs from content feat: CMD-97 isolate breadcrumbs from content Sep 12, 2024
This was referenced Sep 12, 2024
Merged
Merged
@wesleyboar wesleyboar mentioned this pull request Sep 13, 2024
Merged
@wesleyboar wesleyboar marked this pull request as ready for review September 13, 2024 00:08
@wesleyboar wesleyboar merged commit 0aad6ac into main Sep 13, 2024
@wesleyboar wesleyboar deleted the feat/isolate-breadcrumbs-from-content branch September 13, 2024 00:14
@wesleyboar wesleyboar mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar