Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show container since Core-CMS#870 #202

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

wesleyboar
Copy link
Member

Overview / Related

Explicitly do not show breadcrumbs since TACC/Core-CMS#870.

Changes

  • updated code to hide container (and breadcrumbs)

Related

In Core-CMS, breadcrumbs become their own block.

Until now, in `fullwidth.html` templates have had no breadcrumbs.

To continue to not show breadcrumbs, these templates must:
- either explicitely hide breadcrumbs
- or extend Core-CMS fullwidth

I am more comfortable performing the former without testing.

The latter requires testing which reequires many steps.
@wesleyboar wesleyboar marked this pull request as ready for review September 13, 2024 00:03
@wesleyboar wesleyboar merged commit e8081e6 into main Sep 13, 2024
@wesleyboar wesleyboar deleted the feat/isolate-breadcrumbs-from-content branch September 13, 2024 00:04
@wesleyboar wesleyboar restored the feat/isolate-breadcrumbs-from-content branch September 13, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant