fix: do not show breadcrumbs since Core-CMS#870 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Core-CMS, breadcrumbs become their own block. Until now, in `fullwidth.html` templates have had no breadcrumbs. To continue to not show breadcrumbs, these templates must: - either explicitely hide breadcrumbs - or extend Core-CMS fullwidth I am more comfortable performing the former without testing. The latter requires testing which reequires many steps.
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
|
Safe to merge before related Core-CMS PR, because this would just create new empty block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview / Related
Explicitly do not show breadcrumbs since TACC/Core-CMS#870.
Changes
Notes
Reasoning
In Core-CMS, breadcrumbs become their own block. Until now,
fullwidth.htmltemplates of a custom CMS have implicitly had no breadcrumbs. To continue to not show breadcrumbs, these templates must:fullwidth.htmlI am more comfortable performing the former without testing. The latter is more appropriate but requires testing (which requires many steps and documenting) and would be moot if I can migrate the CMS's to Core-CMS-Custom (WP-197) without a custom template (as I have done for some migrated CMS's).