COMP: No longer add BUILD_SHARED_LIBS option #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aims to fix the following CMake Warning from https://open.cdash.org/build/6758579/configure Build: InsightSoftwareConsortium/ITKElastix-macos-10.15--refs/pull/60/merge > CMake Warning (dev) at /Users/runner/work/ITKElastix/build/_deps/elx-src/CMakeLists.txt:37 (option): > Policy CMP0077 is not set: option() honors normal variables. Run "cmake > --help-policy CMP0077" for policy details. Use the cmake_policy command to > set the policy and suppress this warning. > > For compatibility with older versions of CMake, option is clearing the > normal variable 'BUILD_SHARED_LIBS'. Follow-up to commit bb902f7, "COMP: Explicitly disable BUILD_SHARED_LIBS", September 11, 2019. Related to: - pull request #184 "COMP: Explicitly disable BUILD_SHARED_LIBS" - pull request #145 "Make BUILD_SHARED_LIBS do its job" - issue #202 "Elastix 5.0 does not support shared libaray?"
N-Dekker
added a commit
to SuperElastix/manual
that referenced
this pull request
Jun 23, 2023
See also pull request SuperElastix/elastix#283 "COMP: No longer add BUILD_SHARED_LIBS option", merged on September 12, 2020. Removed obsolete text saying: "To build elastix as a library you have to disable the `ELASTIX_BUILD_EXECUTABLE` option in CMake". Related to pull request SuperElastix/elastix#232 commit SuperElastix/elastix@a0c161a "STYLE: Remove ELASTIX_BUILD_EXECUTABLE option -- always build lib + exe" (August 25, 2020)
N-Dekker
added a commit
to SuperElastix/manual
that referenced
this pull request
Jul 17, 2024
See also pull request SuperElastix/elastix#283 "COMP: No longer add BUILD_SHARED_LIBS option", merged on September 12, 2020. Removed obsolete text saying: "To build elastix as a library you have to disable the `ELASTIX_BUILD_EXECUTABLE` option in CMake". Related to pull request SuperElastix/elastix#232 commit SuperElastix/elastix@a0c161a "STYLE: Remove ELASTIX_BUILD_EXECUTABLE option -- always build lib + exe" (August 25, 2020)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix the following CMake Warning from https://open.cdash.org/build/6758579/configure Build: InsightSoftwareConsortium/ITKElastix-macos-10.15--refs/pull/60/merge
Follow-up to commit bb902f7, "COMP: Explicitly disable BUILD_SHARED_LIBS", September 11, 2019.
Related to: