Make BUILD_SHARED_LIBS do its job #145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SHARED_LIBS instead
Member
|
this should be carefully reviewed, as it may break code downstream, for example for the companies using it. |
Contributor
Author
|
It's also failing on Windows: I'm not very familiar with Windows / dll's, but it seems tricky. |
Member
|
Thank you Harmen @haampie for looking into this issue. Unfortunately we don't really have the resources (both man power and computer resources) to support both shared and static, for all platforms. As I discussed with Marius @mstaring earlier today. So unless there is a use case that appears very important to us, we won't actively support building shared elastix libs. Technical considerations:
Hope it's OK to you! |
Member
|
There are many intricacies involved for supporting different types of libs, upstream and downstream. I'm going to close this PR as there are currently no good test cases, and no resources to investigate this carefully. |
N-Dekker
added a commit
that referenced
this pull request
Sep 11, 2019
Attempts to build shared Elastix libraries have led to various problems, including a core dump recently reported by Luisa Sanchez Brea. Pull request #145 "Make BUILD_SHARED_LIBS do its job" by Harmen Stoppels (@haampie) was abandoned because of lack of resources at our side. This commit prevents users from accidentally switching on `BUILD_SHARED_LIBS` for Elastix.
N-Dekker
added a commit
that referenced
this pull request
Sep 16, 2019
Attempts to build shared Elastix libraries have led to various problems, including a core dump recently reported by Luisa Sanchez Brea. Pull request #145 "Make BUILD_SHARED_LIBS do its job" by Harmen Stoppels (@haampie) was abandoned because of lack of resources at our side. This commit prevents users from accidentally switching on the CMake option `BUILD_SHARED_LIBS` for Elastix. Moreover, it drops support for the macro `_ELASTIX_USE_SHARED_LIBRARY`. The manual (TeX file) is adjusted accordingly.
N-Dekker
added a commit
that referenced
this pull request
Sep 16, 2019
Attempts to build shared Elastix libraries have led to various problems, including a core dump recently reported by Luisa Sanchez Brea. Pull request #145 "Make BUILD_SHARED_LIBS do its job" by Harmen Stoppels (@haampie) was abandoned because of lack of resources at our side. This commit prevents users from accidentally switching on the CMake option `BUILD_SHARED_LIBS` for Elastix. Moreover, it drops support for the macro `_ELASTIX_USE_SHARED_LIBRARY`. The manual (TeX file) is adjusted accordingly.
N-Dekker
added a commit
that referenced
this pull request
Sep 12, 2020
Aims to fix the following CMake Warning from https://open.cdash.org/build/6758579/configure Build: InsightSoftwareConsortium/ITKElastix-macos-10.15--refs/pull/60/merge > CMake Warning (dev) at /Users/runner/work/ITKElastix/build/_deps/elx-src/CMakeLists.txt:37 (option): > Policy CMP0077 is not set: option() honors normal variables. Run "cmake > --help-policy CMP0077" for policy details. Use the cmake_policy command to > set the policy and suppress this warning. > > For compatibility with older versions of CMake, option is clearing the > normal variable 'BUILD_SHARED_LIBS'. Follow-up to commit bb902f7, "COMP: Explicitly disable BUILD_SHARED_LIBS", September 11, 2019. Related to: - pull request #184 "COMP: Explicitly disable BUILD_SHARED_LIBS" - pull request #145 "Make BUILD_SHARED_LIBS do its job" - issue #202 "Elastix 5.0 does not support shared libaray?"
N-Dekker
added a commit
that referenced
this pull request
Sep 12, 2020
Aims to fix the following CMake Warning from https://open.cdash.org/build/6758579/configure Build: InsightSoftwareConsortium/ITKElastix-macos-10.15--refs/pull/60/merge > CMake Warning (dev) at /Users/runner/work/ITKElastix/build/_deps/elx-src/CMakeLists.txt:37 (option): > Policy CMP0077 is not set: option() honors normal variables. Run "cmake > --help-policy CMP0077" for policy details. Use the cmake_policy command to > set the policy and suppress this warning. > > For compatibility with older versions of CMake, option is clearing the > normal variable 'BUILD_SHARED_LIBS'. Follow-up to commit bb902f7, "COMP: Explicitly disable BUILD_SHARED_LIBS", September 11, 2019. Related to: - pull request #184 "COMP: Explicitly disable BUILD_SHARED_LIBS" - pull request #145 "Make BUILD_SHARED_LIBS do its job" - issue #202 "Elastix 5.0 does not support shared libaray?"
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% confident if this is correct, but it's an attempt to fix #81.