ENH: Allow building exe and lib of elastix and transformix together #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Dekker
force-pushed
the
Exe-and-Lib-built-together
branch
2 times, most recently
from
f4676a6 to
6050ba9
Compare
N-Dekker
changed the title
N-Dekker
force-pushed
the
Exe-and-Lib-built-together
branch
2 times, most recently
from
5c65946 to
0456515
Compare
N-Dekker
force-pushed
the
Exe-and-Lib-built-together
branch
3 times, most recently
from
074f550 to
be70b85
Compare
N-Dekker
changed the title
N-Dekker
force-pushed
the
Exe-and-Lib-built-together
branch
from
be70b85 to
94ccee4
Compare
N-Dekker
force-pushed
the
Exe-and-Lib-built-together
branch
from
94ccee4 to
0959c35
Compare
In order to ease maintainability of Elastix, always just build both library and the executable. Ensures that the tests (CTest + GTest) cover the source files of both binaries. Was discussed today Aug 24, 2020 with Marius Staring.
N-Dekker
force-pushed
the
Exe-and-Lib-built-together
branch
from
0959c35 to
c8538f7
Compare
N-Dekker
added a commit
to N-Dekker/ITKElastix
that referenced
this pull request
Sep 10, 2020
Removed obsolete `elastix::BaseComponent::InitializeElastixLibrary()` calls, as Elastix is now initialized as a library by default: "ENH: Replace InitializeElastixLibrary() by InitializeElastixExecutable()" SuperElastix/elastix#248 SuperElastix/elastix@ef64fb2 Adjusted CMake `Elastix_LIBRARIES`, as the Elastix library CMake targets are now named elastix_lib and transformix_lib: "ENH: Allow building exe and lib of elastix and transformix together" SuperElastix/elastix#232 SuperElastix/elastix@3944a13
N-Dekker
added a commit
to N-Dekker/ITKElastix
that referenced
this pull request
Sep 11, 2020
Removed obsolete `elastix::BaseComponent::InitializeElastixLibrary()` calls, as Elastix is now initialized as a library by default: "ENH: Replace InitializeElastixLibrary() by InitializeElastixExecutable()" SuperElastix/elastix#248 SuperElastix/elastix@ef64fb2 Adjusted CMake `Elastix_LIBRARIES`, as the Elastix library CMake targets are now named elastix_lib and transformix_lib: "ENH: Allow building exe and lib of elastix and transformix together" SuperElastix/elastix#232 SuperElastix/elastix@3944a13
N-Dekker
added a commit
to N-Dekker/ITKElastix
that referenced
this pull request
Sep 11, 2020
Removed obsolete `elastix::BaseComponent::InitializeElastixLibrary()` calls, as Elastix is now initialized as a library by default: "ENH: Replace InitializeElastixLibrary() by InitializeElastixExecutable()" SuperElastix/elastix#248 SuperElastix/elastix@ef64fb2 Adjusted CMake `Elastix_LIBRARIES`, as the Elastix library CMake targets are now named elastix_lib and transformix_lib: "ENH: Allow building exe and lib of elastix and transformix together" SuperElastix/elastix#232 SuperElastix/elastix@3944a13
N-Dekker
added a commit
to N-Dekker/ITKElastix
that referenced
this pull request
Sep 11, 2020
Removed obsolete `elastix::BaseComponent::InitializeElastixLibrary()` calls, as Elastix is now initialized as a library by default: "ENH: Replace InitializeElastixLibrary() by InitializeElastixExecutable()" SuperElastix/elastix#248 SuperElastix/elastix@ef64fb2 Adjusted CMake `Elastix_LIBRARIES`, as the Elastix library CMake targets are now named elastix_lib and transformix_lib: "ENH: Allow building exe and lib of elastix and transformix together" SuperElastix/elastix#232 SuperElastix/elastix@3944a13
N-Dekker
added a commit
to N-Dekker/ITKElastix
that referenced
this pull request
Sep 12, 2020
Removed obsolete `elastix::BaseComponent::InitializeElastixLibrary()` calls, as Elastix is now initialized as a library by default: "ENH: Replace InitializeElastixLibrary() by InitializeElastixExecutable()" SuperElastix/elastix#248 SuperElastix/elastix@ef64fb2 Adjusted CMake `Elastix_LIBRARIES`, as the Elastix library CMake targets are now named elastix_lib and transformix_lib: "ENH: Allow building exe and lib of elastix and transformix together" SuperElastix/elastix#232 SuperElastix/elastix@3944a13
N-Dekker
added a commit
to N-Dekker/ITKElastix
that referenced
this pull request
Sep 12, 2020
Removed obsolete `elastix::BaseComponent::InitializeElastixLibrary()` calls, as Elastix is now initialized as a library by default: "ENH: Replace InitializeElastixLibrary() by InitializeElastixExecutable()" SuperElastix/elastix#248 SuperElastix/elastix@ef64fb2 Adjusted CMake `Elastix_LIBRARIES`, as the Elastix library CMake targets are now named elastix_lib and transformix_lib: "ENH: Allow building exe and lib of elastix and transformix together" SuperElastix/elastix#232 SuperElastix/elastix@3944a13
N-Dekker
added a commit
to N-Dekker/ITKElastix
that referenced
this pull request
Sep 13, 2020
Removed obsolete `elastix::BaseComponent::InitializeElastixLibrary()` calls, as Elastix is now initialized as a library by default: "ENH: Replace InitializeElastixLibrary() by InitializeElastixExecutable()" SuperElastix/elastix#248 SuperElastix/elastix@ef64fb2 Adjusted CMake `Elastix_LIBRARIES`, as the Elastix library CMake targets are now named elastix_lib and transformix_lib: "ENH: Allow building exe and lib of elastix and transformix together" SuperElastix/elastix#232 SuperElastix/elastix@3944a13
N-Dekker
added a commit
that referenced
this pull request
Jun 22, 2023
Added support for `ELASTIX_BUILD_EXECUTABLE`, allowing to switch off building the elastix and transformix executables, while still building the libraries. Basically reverts pull request #232 commit a0c161a "STYLE: Remove ELASTIX_BUILD_EXECUTABLE option -- always build lib + exe" The ability to suppress building the executables appears necessary for WebAssembly support, as requested by Matt McCormick at #920
N-Dekker
added a commit
that referenced
this pull request
Jun 22, 2023
Added support for `ELASTIX_BUILD_EXECUTABLE`, allowing to switch off building the elastix and transformix executables, while still building the libraries. Basically reverts pull request #232 commit a0c161a "STYLE: Remove ELASTIX_BUILD_EXECUTABLE option -- always build lib + exe" The ability to suppress building the executables appears necessary for WebAssembly support, as requested by Matt McCormick at #920
N-Dekker
added a commit
that referenced
this pull request
Jun 23, 2023
Added support for `ELASTIX_BUILD_EXECUTABLE`, allowing to switch off building the elastix and transformix executables, while still building the libraries. Basically reverts pull request #232 commit a0c161a "STYLE: Remove ELASTIX_BUILD_EXECUTABLE option -- always build lib + exe" The ability to suppress building the executables appears necessary for WebAssembly support, as requested by Matt McCormick at #920
N-Dekker
added a commit
that referenced
this pull request
Jun 23, 2023
Added support for `ELASTIX_BUILD_EXECUTABLE`, allowing to switch off building the elastix and transformix executables, while still building the libraries. Basically reverts pull request #232 commit a0c161a "STYLE: Remove ELASTIX_BUILD_EXECUTABLE option -- always build lib + exe" (August 25, 2020). The ability to suppress building the executables appears necessary for WebAssembly support, as requested by Matt McCormick at pull request #920
N-Dekker
added a commit
to SuperElastix/manual
that referenced
this pull request
Jun 23, 2023
See also pull request SuperElastix/elastix#283 "COMP: No longer add BUILD_SHARED_LIBS option", merged on September 12, 2020. Removed obsolete text saying: "To build elastix as a library you have to disable the `ELASTIX_BUILD_EXECUTABLE` option in CMake". Related to pull request SuperElastix/elastix#232 commit SuperElastix/elastix@a0c161a "STYLE: Remove ELASTIX_BUILD_EXECUTABLE option -- always build lib + exe" (August 25, 2020)
N-Dekker
added a commit
that referenced
this pull request
Jun 23, 2023
Added support for `ELASTIX_BUILD_EXECUTABLE`, allowing to switch off building the elastix and transformix executables, while still building the libraries. Basically reverts pull request #232 commit a0c161a "STYLE: Remove ELASTIX_BUILD_EXECUTABLE option -- always build lib + exe" (August 25, 2020). The ability to suppress building the executables appears necessary for WebAssembly support, as requested by Matt McCormick at pull request #920
N-Dekker
added a commit
to SuperElastix/manual
that referenced
this pull request
Jul 17, 2024
See also pull request SuperElastix/elastix#283 "COMP: No longer add BUILD_SHARED_LIBS option", merged on September 12, 2020. Removed obsolete text saying: "To build elastix as a library you have to disable the `ELASTIX_BUILD_EXECUTABLE` option in CMake". Related to pull request SuperElastix/elastix#232 commit SuperElastix/elastix@a0c161a "STYLE: Remove ELASTIX_BUILD_EXECUTABLE option -- always build lib + exe" (August 25, 2020)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enabled GoogleTest on the CI (Azure pipelines).