add param to config files, mutex locks, stack size fix #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMacenski
requested changes
Dec 21, 2018
| use_response_expansion: true | ||
|
|
||
| # Load Map Parameters | ||
| inverted_laser: true No newline at end of file |
| use_response_expansion: true | ||
|
|
||
| # Load Map Parameters | ||
| inverted_laser: true No newline at end of file |
src/slam_toolbox.cpp
Outdated
| { | ||
| ros::init(argc, argv, "slam_toolbox"); | ||
| ros::NodeHandle nh; | ||
| const rlim_t max_stack_size = 16777216; |
Owner
There was a problem hiding this comment.
... what's this magic number? can't we round to something nice, say 20MB
Owner
There was a problem hiding this comment.
and add as a top preprocessor variable. #define max_stack_size 20000000 //comment explaining
SteveMacenski
approved these changes
Dec 21, 2018
malban
pushed a commit
to malban/slam_toolbox
that referenced
this pull request
Jul 18, 2022
malban
pushed a commit
to malban/slam_toolbox
that referenced
this pull request
Jul 19, 2022
malban
pushed a commit
to malban/slam_toolbox
that referenced
this pull request
Jul 19, 2022
malban
added a commit
to malban/slam_toolbox
that referenced
this pull request
Sep 22, 2022
* Add graph edges to graph visualization marker. (SteveMacenski#502) * Clear markers for graph visualization to account for removed nodes. (SteveMacenski#503) * Publish PoseWithCovarianceStamped message with each scan match. (SteveMacenski#504) * Publish PoseWithCovarianceStamped message with each scan match. * Refactor code to return covariance as a output parameter instead of storing in the range scan object. * Linting fixes. * Publish pose with covariance in localization mode. (SteveMacenski#508) * Visualize localization nodes and edges with different colors in the pose graph marker message. (SteveMacenski#509) * Add map_and_localization node that supports toggling between mapping and localization modes with a service. (SteveMacenski#510) * Stop ceres problem from freeing loss function (SteveMacenski#519) (SteveMacenski#520) Co-authored-by: john-maidbot <78750993+john-maidbot@users.noreply.github.com> * Experimental changes. * Initial experiments (pose w cov stamped for each scan msg, better graph edge vis, tweak to continuous scan matching, etc) (SteveMacenski#2) * Add option to perform continuous scan matching to update the transform and pose even when the minimum travel distance or heading have not been reached for adding the scan into the map. * Add graph edges to graph visualization marker. (SteveMacenski#502) * Clear markers for graph visualization to account for removed nodes. (SteveMacenski#503) * Publish PoseWithCovarianceStamped message with each scan match. (SteveMacenski#504) * Publish PoseWithCovarianceStamped message with each scan match. * Refactor code to return covariance as a output parameter instead of storing in the range scan object. * Linting fixes. * Tweaks to parameter documentation. * Refactor scan match only logic to be based on a time interval. * Need to install async_pruned_slam_toolbox lib * Add localization status publisher (SteveMacenski#3) * Lint slam_toolbox_async_pruned.cpp * Change a lot of INFO prints related to pruning to DEBUG * Modified pause behavior. Added start/stop services and reset functionality. (SteveMacenski#5) * Modified pause behavior. Added reset service * One last book keeping issue. Dont publish graph without subscribers * Add start/stop service * Enable switching from mapping to localization mode (SteveMacenski#6) * Lidar qos is sensor data (best effort) (SteveMacenski#7) * Lidar qos is sensor data (best effort) * typo * Set initial slam pose via subscription (SteveMacenski#8) * Freeze map nodes when localizing + don't partition the graph when popping localization nodes + don't crash when resetting in localization mode (SteveMacenski#9) * Set non-localization nodes to constant * Forbid removing localization nodes if we don't have enough connections to the map graph * Fix crash on reset * unfreeze nodes when exiting localization mode * Don't freeze nodes that aren't part of the problem yet * Merge fixes. * Support resetting mapping pose. Co-authored-by: Marc Alban <marcalban@gmail.com> Co-authored-by: Marc Alban <marcalban@hatchbed.com> Co-authored-by: Justin Nguyen <justin@maidbot.com> Co-authored-by: Ketan Kharche <47426551+ketan-maidbot@users.noreply.github.com>
malban
pushed a commit
to malban/slam_toolbox
that referenced
this pull request
Oct 13, 2022
* Use new tf2 listener constructor * Update
jsongCMU
pushed a commit
to jsongCMU/slam_toolbox
that referenced
this pull request
Oct 16, 2022
…anup Mapping cleanup
Zarqu0n
added a commit
to Zarqu0n/slam_toolbox
that referenced
this pull request
Aug 21, 2024
Refactor slam_toolbox_common.hpp to initialize update_map_once_ flag …
SteveMacenski
pushed a commit
that referenced
this pull request
Nov 17, 2025
* remove pose2D (#8) Remove pose2D follwing Remove Pose2D deprecation, No conflicts * change initialize part:geometry_msgs::msg::Pose() --------- Co-authored-by: hyunsehyun <wjwjwj20002@gachon.ac.kr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.