Introduce Javy.JSON builtins #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces `Javy.JSON` builtins and bumps the package version to 1.0.0. It's important to note that this is a breaking change because it introduces new JavaScript builtins for faster JSON parsing and stringifying from stdin and to stdout. In order to use v1.0.0 of this package, users need the latest shopify cli, which contains `javy` v3.1.0
Comment on lines
-20
to
-21
| "peerDependencies": { | ||
| "javy": "^0.1.0" |
There was a problem hiding this comment.
Why did we drop the peer dependency? 👀
There was a problem hiding this comment.
The javy npm dependency is what brings the fs namespace, which is no longer used (fs.{readSync, writeSync}).
There was a problem hiding this comment.
Currently unable to build extensions on the linked CLI branch- will circle back to this once that's resolved: Shopify/cli#4444 (comment)
saulecabrera
added a commit
to Shopify/cli
that referenced
this pull request
Sep 13, 2024
This commit ensures that new functions are bootstrapped with version 1.0.0 of the `@shopify/function_javascript` package, which includes the changes in Shopify/shopify-function-javascript#16 To 🎩 * Create a new app and JavaScript extension. * Build the app * Run the app
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces
Javy.JSONbuiltins and bumps the package version to 1.0.0.It's important to note that this is a breaking change because it introduces new JavaScript builtins for faster JSON parsing and stringifying from stdin and to stdout.
In order to use v1.0.0 of this package, users need the latest shopify cli, which contains
javyv3.1.0🎩
@shopify/shopify_functionv0.1.0in the package.json, with a GitHub dependency ("@shopify/shopify_function": "saulecabrera/shopify-function-javascript#javy-json-v1") or a local dependency (by cloning my repo and switching to this branch)