Skip to content

Commit

Permalink
[Functions] Bump @shopify/function_javascript to v 1.0.0
Browse files Browse the repository at this point in the history
This commit ensures that new functions are bootstrapped with version
1.0.0 of the `@shopify/function_javascript` package, which includes the
  changes in Shopify/shopify-function-javascript#16

To 🎩

* Create a new app and JavaScript extension.
* Build the app
* Run the app
  • Loading branch information
saulecabrera committed Sep 13, 2024
1 parent 3494b53 commit 002f756
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions packages/app/src/cli/services/generate/extension.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,6 @@ describe('getFunctionRuntimeDependencies', () => {

// Then
expect(got.find((dep) => dep.name === '@shopify/shopify_function')).toBeTruthy()
expect(got.find((dep) => dep.name === 'javy')).toBeTruthy()
})

test('no-ops for non-JS functions', async () => {
Expand All @@ -533,6 +532,5 @@ describe('getFunctionRuntimeDependencies', () => {

// Then
expect(got.find((dep) => dep.name === '@shopify/shopify_function')).toBeFalsy()
expect(got.find((dep) => dep.name === 'javy')).toBeFalsy()
})
})
2 changes: 1 addition & 1 deletion packages/app/src/cli/services/generate/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ function getSrcFileExtension(extensionFlavor: ExtensionFlavorValue): SrcFileExte
export function getFunctionRuntimeDependencies(templateLanguage: string): DependencyVersion[] {
const dependencies: DependencyVersion[] = []
if (templateLanguage === 'javascript') {
dependencies.push({name: '@shopify/shopify_function', version: '0.1.0'}, {name: 'javy', version: '0.1.1'})
dependencies.push({name: '@shopify/shopify_function', version: '1.0.0'})
}
return dependencies
}
Expand Down

0 comments on commit 002f756

Please sign in to comment.