-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Functions] Bump @shopify/function_javascript to v 1.0.0
#4448
Conversation
This commit ensures that new functions are bootstrapped with version 1.0.0 of the `@shopify/function_javascript` package, which includes the changes in Shopify/shopify-function-javascript#16 To 🎩 * Create a new app and JavaScript extension. * Build the app * Run the app
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/retry.d.ts@@ -10,7 +10,6 @@
* @param performAction - The action to perform.
* @param recoveryProcedure - The recovery procedure to perform if the action
* fails the first time.
- * @param retries - The number of times to retry the action if an error happens.
* @returns The result of the action.
*/
-export declare function performActionWithRetryAfterRecovery<T>(performAction: () => Promise<T>, recoveryProcedure: () => Promise<unknown>, retries?: number): Promise<T>;
\ No newline at end of file
+export declare function performActionWithRetryAfterRecovery<T>(performAction: () => Promise<T>, recoveryProcedure: () => Promise<unknown>): Promise<T>;
\ No newline at end of file
|
Coverage report
Test suite run success1868 tests passing in 849 suites. Report generated by 🧪jest coverage report action from 002f756 |
/snapit |
🫰✨ Thanks @saulecabrera! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
Code LGTM! 🎩:
|
This commit ensures that new functions are bootstrapped with version 1.0.0 of the
@shopify/function_javascript
package, which includes thechanges in Shopify/shopify-function-javascript#16
Note that the
javy
npm dependency is no longer required as per Shopify/shopify-function-javascript#16How to test your changes?
To 🎩
javy_quickjs_provider_v3
namespace.Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist