-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always install latest
Hydrogen CLI when running create-hydrogen script
#1873
Conversation
We detected some changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL!
But unsure if we can make this work without installing a remote version in our monorepo with latest
🤔
b7241fc
to
ddc182a
Compare
@@ -13,7 +13,7 @@ | |||
"typecheck": "tsc --noEmit" | |||
}, | |||
"dependencies": { | |||
"@shopify/cli-hydrogen": "^7.1.0" | |||
"@shopify/cli-hydrogen": "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Moving here for threading)
But unsure if we can make this work without installing a remote version in our monorepo with
latest
🤔
@frandiox Hm, yeah. I'm not sure what's causing the failure in CI here. But the latest
tag is published by default and it's always available to install through npm:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gfscott it looks like the package lock file needs to get updated. Just run npm install
from the root of the project, and push the changes to the package lock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right. Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went from a one line change to over 1k 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂 😭
Alsooo... did it break a bunch of stuff? I see two failed actions, they seem to be related to the node version? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm going to revert this. Changesets can't deal with non-semver values so this isn't going to work in practice.
We'll have to just make sure that we always bump the create-hydrogen
dependency whenever there's a CLI bump. Otherwise the create flow gets out of sync. Annoying!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if something like link from chageset would help here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooo that's a good thought
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
0fea466
to
3214e6a
Compare
WHY are these changes introduced?
People frequently get an annoying message telling them to update the package they're installing for the first time, which is wack:
WHAT is this pull request doing?
Updates the create-hydrogen package.json to always install the
latest
version of the Hydrogen CLI. Using a tag as a version specifier in package.json is perfectly valid and it stands to reason that if you're running thecreate
script, then you want to install the latest dependencies.Checklist
I've added tests to cover my changesI've added or updated the documentation