Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changeset config to link create-hydrogen to dependencies #1942

Closed
wants to merge 1 commit into from

Conversation

gfscott
Copy link
Contributor

@gfscott gfscott commented Apr 4, 2024

Follow up to #1873 — instead of installing latest, this links the create-hydrogen package to other packages it depends on.

We don't bump create-hydrogen's version that often because it's so simple, so it can get out of sync with other packages, even though it should basically always be installing the latest dependencies.

Linking the packages in Changesets means create-hydrogen will always get bumped when one of its dependencies does, which should lead to the expected behavior.

I'm linking these packages because they're the ones that are included in @next releases and create-hydrogen should always be up to date for testing purposes.
image

@gfscott gfscott requested a review from wizardlyhel April 4, 2024 15:32
@gfscott gfscott closed this Apr 4, 2024
@gfscott gfscott removed the request for review from wizardlyhel April 4, 2024 15:40
@gfscott
Copy link
Contributor Author

gfscott commented Apr 4, 2024

Closing this because a little more investigation showed it's a build error in the @next publishing workflow that caused package hashes to get out of sync in this case.

This might still be a worthwhile idea but closing the issue because it's unrelated. Carry on

@gfscott gfscott deleted the gfscott-link-create branch April 4, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant