Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Always install latest Hydrogen CLI when running create-hydrogen script" #1884

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

gfscott
Copy link
Contributor

@gfscott gfscott commented Mar 21, 2024

Reverts #1873

See this comment for details

@gfscott gfscott requested review from blittle and frandiox March 21, 2024 17:47
@gfscott gfscott self-assigned this Mar 21, 2024
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

Copy link
Contributor

shopify bot commented Mar 21, 2024

Oxygen deployed a preview of your revert-1873-gfscott-create-with-latest-cli branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment March 21, 2024 5:48 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment March 21, 2024 5:48 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment March 21, 2024 5:48 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment March 21, 2024 5:48 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment March 21, 2024 5:48 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment March 21, 2024 5:48 PM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to make this work we might need to remove create-hydrogen from the NPM workspace, and avoid running npm i in its folder in our monorepo (that would install the whole Hydrogen CLI again from the NPM registry).
I guess we can revert for now.

@blittle
Copy link
Contributor

blittle commented Mar 21, 2024

I think to make this work we might need to remove create-hydrogen from the NPM workspace, and avoid running npm i in its folder in our monorepo (that would install the whole Hydrogen CLI again from the NPM registry). I guess we can revert for now.

That's probably a good solution. I don't think create-hydrogen needs to be internally linked.

@gfscott
Copy link
Contributor Author

gfscott commented Mar 21, 2024

PNPM handles this nicely, but that's another can of worms 😅

I'll revert for now, let's sort out alternative approaches separately

@gfscott gfscott merged commit 10031a2 into main Mar 21, 2024
13 checks passed
@gfscott gfscott deleted the revert-1873-gfscott-create-with-latest-cli branch March 21, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants