[email protected]: Fix checkver & autoupdate, add suggest, add architecture field to support 64-bit only #16378
Conversation
WalkthroughUpdated Changes
Sequence Diagram(s)sequenceDiagram
participant Parser as Manifest parser
participant GH as GitHub Releases API
participant Updater as autoupdate resolver
rect rgb(240,250,240)
Note over Parser,GH: Structured checkver using Releases API
end
Parser->>GH: GET /repos/ImminentFate/CompactGUI/releases
GH-->>Parser: JSON releases
Parser->>Parser: extract tags with jsonpath `$..tag_name` and apply regex `v([\\d.]+)`
alt version found
Parser->>Updater: build `architecture.64bit` URL (v$version)
Updater-->>Parser: fetch `CompactGUI.exe` from `architecture.64bit.url`
else no version
Parser-->>Parser: fail/version not found
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-10-19T13:58:23.389ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. compactgui
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/compactgui.json(1 hunks)
🔇 Additional comments (1)
bucket/compactgui.json (1)
15-19: ✓ checkver regex correctly filters out all prerelease versions.The structured checkver implementation successfully excludes prerelease tags. Verification against the GitHub API confirms the regex pattern
v([\\d.]+)\"matches only stable semantic versions (v3.8.0, v3.7.0, etc.) and rejects all prerelease variants (v4.0.0-beta., v3.4.0-alpha.), achieving the intended goal of avoiding unstable releases.
|
/verify |
|
All changes look good. Wait for review from human collaborators. compactgui
|
|
Related: #16379. |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/compactgui.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: o-l-a-v
PR: ScoopInstaller/Extras#16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
📚 Learning: 2025-10-19T13:58:23.389Z
Learnt from: o-l-a-v
PR: ScoopInstaller/Extras#16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Applied to files:
bucket/compactgui.json
🪛 Biome (2.1.2)
bucket/compactgui.json
[error] 13-13: Expected a property but instead found '}'.
Expected a property here.
(parse)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/compactgui.json (3)
22-26: Checkver conversion to GitHub Releases API is sound for filtering stable versions.The regex
v([\\d.]+)correctly excludes prerelease versions by capturing only numeric segments before hyphens (e.g.,v4.0.0-beta.5→4.0.0mismatch). This aligns with the PR objective to "exclude prereleases" since only stable versions likev3.8.0will have corresponding tags.
27-33: Autoupdate restructuring appropriately removes broken hash extraction.The
autoupdateblock now omits the hash field, which is the correct approach per prior discussion: the HTML scraping mechanism no longer works in newer CompactGUI releases, and GitHub asset digests aren't available for v3.8.0 (only in beta versions). This aligns with the learnings from the repository context.
6-8: Dependency suggestion for .NET Desktop Runtime is appropriate.The new
suggestblock correctly declares the .NET Desktop Runtime dependency, which is necessary for running the 64-bit CompactGUI executable on Windows systems that lack it.
z-Fng
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. compactgui
|
2 participants
Fixed checkver
Non-stable releases are not marked as prerelease in GitHub releases. Thus checkver logic should filter out non-stable releases.
Removed autoupdate hash
Newer releases don't have checksum in the release notes anymore, but checksum is listed in GitHub assets digest.
Add suggest
Requires .NET desktop runtime 9.0 to function properly.
Add architecture field to support 64-bit only
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
Chores
New Features