Skip to content

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Oct 19, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated version detection configuration to use an alternative API endpoint and extraction method for improved version checking accuracy.

@coderabbitai
Copy link

coderabbitai bot commented Oct 19, 2025

Walkthrough

The checkver configuration in bucket/duplicati.json was updated to use a new GitHub API endpoint with added JSONPath extraction support and a modified regex pattern for version detection.

Changes

Cohort / File(s) Summary
Version detection configuration
bucket/duplicati.json
Updated checkver object: added jsonpath field, changed regex to a broader pattern, and updated url to point to GitHub releases API endpoint instead of tags page. Homepage entry reordered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

review-needed

Poem

🐰 A config update hops into place,
JSONPath and regex now embrace,
GitHub's API sings a new song,
Version detection won't steer us wrong!
✨ Duplicati's tail now wags with grace!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[email protected]_stable_2025-03-04: Fix checkver and order of manifest" directly corresponds to the changes in the pull request. According to the raw summary, the checkver configuration in bucket/duplicati.json was updated with a new jsonpath field, regex pattern change, and url update, while the homepage entry was reordered. The title is specific, follows the conventional format specified in the template (manifest-name@version: description), and clearly communicates the primary changes. This title enables a reviewer scanning the history to understand the purpose of the changeset without ambiguity.
Description Check ✅ Passed The PR description includes both required checklist items from the template, each marked as complete: the use of conventional PR title format and confirmation of reading the Contributing Guide. While the description is minimal and lacks additional context about the specific changes or issue references, the template's explicit requirements are fulfilled. The template itself suggests that the general summary should be provided in the title (as noted in the template comments), which has been done effectively. The description meets the basic structural requirements of the template by including the two mandatory checklist items in their completed state.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 123b8bb and bafdd86.

📒 Files selected for processing (1)
  • bucket/duplicati.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/duplicati.json (2)

4-4: Acceptable manifest field reordering.

The homepage field reordering is a minor cosmetic change that addresses the "order of manifest" mentioned in the PR title. No functional impact.


54-56: Verify checkver configuration compatibility with Scoop.

The checkver update migrates from an unspecified endpoint to GitHub's stable /releases/latest API with JSONPath extraction. This is a solid improvement for robustness.

However, ensure that:

  1. The target Scoop version supports the jsonpath field in checkver configurations
  2. The GitHub API endpoint reliably returns the expected JSON structure with a tag_name field
  3. The regex "v(.*)" correctly extracts the version string from release tags

The regex pattern aligns well with the autoupdate URLs (which prepend v$version), so version substitution should work as expected.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

duplicati

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants