-
Notifications
You must be signed in to change notification settings - Fork 1.5k
zed: Update to version 0.208.4, switch to official release #16346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated the Zed Scoop manifest to 0.208.4, switched the 64-bit distribution from a ZIP to an Inno Setup (.exe) release on zed-industries GitHub, added an installer extraction script, adjusted Changes
Sequence Diagram(s)sequenceDiagram
participant Scoop as Scoop client
participant GH as GitHub Releases (zed-industries)
participant Installer as InnoSetup .exe
participant Script as installer script (innoextract)
participant FS as Target filesystem (bin\*)
Note over GH,Installer #D6EAF8: New release artifact: Zed-x86_64.exe
Scoop->>GH: fetch release metadata (checkver/autoupdate)
Scoop->>GH: download Zed-x86_64.exe
Scoop->>Installer: invoke installer extraction (installer.script)
Installer->>Script: expand InnoArchive (innoextract)
Script->>FS: place `bin\zed` and `bin\zed.exe`
Scoop->>FS: register bins and complete installation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. zed
|
|
The executable file is a setup file so this is invalid ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/zed.json (1)
8-9: Switch to official asset: verify hash and available architectures.
- Please confirm the SHA256 against the release asset and that this EXE is indeed Inno Setup (needed for extraction).
- If an official Windows ARM64 build exists, consider adding an
arm64architecture block.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/zed.json(1 hunks)
🔇 Additional comments (4)
bucket/zed.json (4)
2-2: Version bump looks good.
29-29: checkver via GitHub: good.
32-32: autoupdate URL pattern: good.Uses
v$version/Zed-x86_64.exe, which matches the new upstream convention.Please confirm future releases keep the same asset name.
12-17: Simplify installer script to a single extraction
Remove the first call and combine parameters. For example:"Expand-InnoArchive -Path \"$dir\\$fname\" -DestinationPath \"$dir\" -Removal"If you only need a subfolder, replace
-DestinationPathwith-ExtractDir '{app}'or use the correct code-function token (e.g.{code:GetInstallDir}) instead of'{code_GetInstallDir}'. Test locally to confirm the final install path.
|
This PR added a duplicate of bin / shims, which made update and uninstall fail. Ref: #16441. |
#16346 (comment) It seems to be a bug in Scoop Core. We may consider removing bin/zed.
|
Summary
Zed now have official Windows build. This PR migrates the Zed manifest from the unofficial Windows build to the new official one.
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit