Skip to content

Conversation

@qyurila
Copy link
Contributor

@qyurila qyurila commented Oct 16, 2025

Summary

Zed now have official Windows build. This PR migrates the Zed manifest from the unofficial Windows build to the new official one.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated Zed to version 0.208.4.
    • Switched 64-bit download to the official executable release and updated its checksum.
    • Added installer extraction steps for the official installer to streamline setup.
    • Moved version checking and autoupdate to the official repository with a direct executable path.
    • Exposed both CLI and GUI executable entries for clearer launch options.

@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2025

Walkthrough

Updated the Zed Scoop manifest to 0.208.4, switched the 64-bit distribution from a ZIP to an Inno Setup (.exe) release on zed-industries GitHub, added an installer extraction script, adjusted bin entries, updated hashes, and pointed checkver/autoupdate to GitHub releases.

Changes

Cohort / File(s) Summary of changes
Zed Scoop manifest
bucket/zed.json
Version 0.207.4 → 0.208.4; 64-bit url changed from deevus ZIP to zed-industries/.../Zed-x86_64.exe; added installer section with InnoArchive extraction script; bin changed from "zed.exe" to ["bin\\zed","bin\\zed.exe"]; updated 64-bit hash; checkver switched to github source; autoupdate updated to direct GitHub release executable path.

Sequence Diagram(s)

sequenceDiagram
    participant Scoop as Scoop client
    participant GH as GitHub Releases (zed-industries)
    participant Installer as InnoSetup .exe
    participant Script as installer script (innoextract)
    participant FS as Target filesystem (bin\*)

    Note over GH,Installer #D6EAF8: New release artifact: Zed-x86_64.exe

    Scoop->>GH: fetch release metadata (checkver/autoupdate)
    Scoop->>GH: download Zed-x86_64.exe
    Scoop->>Installer: invoke installer extraction (installer.script)
    Installer->>Script: expand InnoArchive (innoextract)
    Script->>FS: place `bin\zed` and `bin\zed.exe`
    Scoop->>FS: register bins and complete installation
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I hop, I patch, I swap the crate,
An exe arrived at version eight.
I unpacked archives, set bins just so,
Hashes hummed, releases glow.
— Rabbit dev, nibbling bytes with a carrot-shaped light 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "zed: Update to version 0.208.4, switch to official release" directly relates to the main changes in the changeset. It follows a conventional format (manifest-name: summary) appropriate for this repository and clearly identifies both primary changes: the version bump to 0.208.4 and the switch from an unofficial to official release source. The title is concise, specific, and avoids vague language, making it clear to teammates scanning the history what the primary objective is.
Description Check ✅ Passed The pull request description follows the required template structure with a clear summary section explaining that Zed now has an official Windows build and this PR migrates from the unofficial to official build. Both required checkboxes for the conventional PR title format and the Contributing Guide confirmation are properly checked. The description adequately communicates the motivation and scope of the changes, though it does not include issue references (Closes/Relates), which appear to be optional based on the commented-out template section.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbdfb70 and 4f96b06.

📒 Files selected for processing (1)
  • bucket/zed.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/zed.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

zed

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@qyurila
Copy link
Contributor Author

qyurila commented Oct 16, 2025

The executable file is a setup file so this is invalid (innosetup or installer option might be needed). Will update later and apply another PR. Sorry for the disturbance.

@qyurila qyurila closed this Oct 16, 2025
@qyurila qyurila reopened this Oct 16, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/zed.json (1)

8-9: Switch to official asset: verify hash and available architectures.

  • Please confirm the SHA256 against the release asset and that this EXE is indeed Inno Setup (needed for extraction).
  • If an official Windows ARM64 build exists, consider adding an arm64 architecture block.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a364a8e and fbdfb70.

📒 Files selected for processing (1)
  • bucket/zed.json (1 hunks)
🔇 Additional comments (4)
bucket/zed.json (4)

2-2: Version bump looks good.


29-29: checkver via GitHub: good.


32-32: autoupdate URL pattern: good.

Uses v$version/Zed-x86_64.exe, which matches the new upstream convention.

Please confirm future releases keep the same asset name.


12-17: Simplify installer script to a single extraction
Remove the first call and combine parameters. For example:

"Expand-InnoArchive -Path \"$dir\\$fname\" -DestinationPath \"$dir\" -Removal"

If you only need a subfolder, replace -DestinationPath with -ExtractDir '{app}' or use the correct code-function token (e.g. {code:GetInstallDir}) instead of '{code_GetInstallDir}'. Test locally to confirm the final install path.

@chawyehsu chawyehsu merged commit 2918782 into ScoopInstaller:master Oct 16, 2025
3 checks passed
@qyurila qyurila deleted the patch-1 branch October 17, 2025 00:19
@z-Fng z-Fng mentioned this pull request Oct 17, 2025
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Oct 23, 2025
2 tasks
@o-l-a-v
Copy link
Contributor

o-l-a-v commented Oct 23, 2025

This PR added a duplicate of bin / shims, which made update and uninstall fail. Ref: #16441.

@z-Fng
Copy link
Member

z-Fng commented Oct 23, 2025

This PR added a duplicate of bin / shims, which made update and uninstall fail. Ref: #16441.

#16346 (comment) It seems to be a bug in Scoop Core. We may consider removing bin/zed.

  • zed.exe (root): GUI application
  • bin/zed: Shell script for WSL integration
  • bin/zed.exe: Zed CLI binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants