[email protected]: Switch to ZIP package, add architecture field to support 64-bit only #16054

val1984 · 2025-08-25T13:33:10Z

~~UniGetUI.Installer.exe does not seem to be using InnoSetup anymore (innounp doesn't manage to unpack it).~~

Closes [email protected]: decompress error #16053
Relates to [email protected]: Use newly added portable mode #14863

This PR makes the following changes:

Update autoupdate to use the zip package instead of Inno Setup package.
Update homepage & description.
Add architecture field to fix incorrect architecture support. Move URL & hash under architecture.64bit.
Simplify persist & pre_install.

Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
I have read the Contributing Guide

Summary by CodeRabbit

New Features
- Switched installation to a portable 64-bit ZIP, enabling easier setup and portability.
- User data now persists across updates (ForceUniGetUIPortable and Settings).
Chores
- Updated download source and checksum to the ZIP distribution.
- Streamlined update checks to pull versions directly from GitHub.
- Simplified manifest by removing legacy installer-specific fields and scripts.
- Adjusted auto-update hash matching to align with the ZIP artifact.

Becuase UniGetUI.Installer.exe does not seem to be using InnoSetup anymore (innounp doesn't manage to unpack it). Fixes ScoopInstaller#16053

github-actions · 2025-08-25T13:34:46Z

All changes look good.

Wait for review from human collaborators.

unigetui

val1984 · 2025-08-26T11:22:02Z

/verify

github-actions · 2025-08-26T11:23:14Z

All changes look good.

Wait for review from human collaborators.

unigetui

coderabbitai · 2025-09-10T08:01:18Z

Walkthrough

The Scoop manifest for UniGetUI was updated to use a 64-bit ZIP artifact instead of an Inno Setup EXE. Installer-specific fields were removed, new persistence and version-check fields were added, and URLs/hashes for both current and autoupdate paths were updated accordingly.

Changes

Cohort / File(s)	Summary
Scoop manifest update `bucket/unigetui.json`	Switched top-level url/hash to `UniGetUI.x64.zip`; removed `innosetup` and `pre_install`; added `persist` (ForceUniGetUIPortable, Settings) and `checkver.github`; updated `autoupdate.url` to ZIP and `autoupdate.hash.regex` to match ZIP SHA256 line.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant S as Scoop
  participant G as GitHub Releases
  participant FS as Filesystem

  Note over S,G: Install/Update using ZIP (replaces Inno Setup EXE flow)

  U->>S: scoop install/update unigetui
  S->>G: GET UniGetUI.x64.zip (versioned URL)
  G-->>S: ZIP bytes
  S->>FS: Extract ZIP to app dir
  S->>FS: Create persist dirs (ForceUniGetUIPortable, Settings)
  S-->>U: Installation complete

  break Check for new versions
    S->>G: checkver (GitHub)
    G-->>S: latest release tag
    S->>G: autoupdate.hash.regex (fetch checksum text)
    G-->>S: SHA256 line for UniGetUI.x64.zip
  end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (4 passed, 1 warning)

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes Check	⚠️ Warning	The PR introduces new manifest properties for persistence (persist) and update verification (checkver) that are not required to address the decompression error described in issue #16053 and go beyond the needed scope of switching to the ZIP distribution.	Please limit this PR to the core fix of replacing the installer with the ZIP artifact and consider moving the persist and checkver additions to a separate enhancement PR to keep the scope focused on resolving the decompression error.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly follows the repository’s conventional pattern by specifying the manifest and version followed by a concise summary of switching to the ZIP distribution to fix the broken installer, accurately reflecting the core change.
Linked Issues Check	✅ Passed	The changes correctly switch the manifest’s URL, hash, and autoupdate settings to the ZIP distribution as required by issue #16053, effectively resolving the decompression failure by avoiding the broken Inno Setup executable.
Description Check	✅ Passed	The PR description clearly summarizes the extraction failure with the Inno Setup executable, states that the manifest now points to the ZIP file, includes the closing of issue #16053, and confirms adherence to the repository’s checklist for title conventions and contributing guidelines.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Poem

I hopped from EXE to a zippy new way,
No more innosetup on my install day.
I stash my Settings where carrots persist,
Checkver sniffs versions I don’t want to miss.
With hashes aligned, I thump in delight—
Scoop’s burrow is tidy, updates run right. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes Check	⚠️ Warning	The PR introduces new manifest properties for persistence (persist) and update verification (checkver) that are not required to address the decompression error described in issue #16053 and go beyond the needed scope of switching to the ZIP distribution.	Please limit this PR to the core fix of replacing the installer with the ZIP artifact and consider moving the persist and checkver additions to a separate enhancement PR to keep the scope focused on resolving the decompression error.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues Check	✅ Passed	The changes correctly switch the manifest’s URL, hash, and autoupdate settings to the ZIP distribution as required by issue #16053, effectively resolving the decompression failure by avoiding the broken Inno Setup executable.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Title Check	✅ Passed	The PR title correctly highlights the central change to using a ZIP package, but it also mentions adding an architecture field and a version bump to 3.3.5, neither of which are reflected in the supplied manifest diff. These discrepancies could confuse readers about the actual modifications. Therefore, while the title is partially related, it doesn’t fully or accurately convey the implemented changes.
Description Check	✅ Passed	The pull request description includes the required issue references “Closes #16053” and “Relates to #14863”, provides a clear summary of changes, and marks both checklist items as completed according to the repository template. It follows the conventional PR title format and confirms reading the contributing guide. All mandatory sections from the template are present and adequately filled out.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

bucket/unigetui.json (1)
28-28: Harden hash regex to tolerate spacing and optional <code> tags
Update in bucket/unigetui.json (line 28):
-           "regex": "UniGetUI.x64.zip SHA256: <code>$sha256</code>"
+           "regex": "UniGetUI\\.x64\\.zip\\s*SHA256:\\s*(?:<code>)?($sha256)(?:</code>)?"

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c266491 and a39bc86.

📒 Files selected for processing (1)

bucket/unigetui.json (2 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.

Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.

📚 Learning: 2025-09-05T09:41:52.653Z

Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.

Applied to files:

bucket/unigetui.json

📚 Learning: 2025-09-05T09:41:52.653Z

Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.

Applied to files:

bucket/unigetui.json

🔇 Additional comments (1)

bucket/unigetui.json (1)

25-25: Autoupdate URL looks correct for the ZIP artifact.

No issues spotted; this will track future releases properly.

bucket/unigetui.json

Skylark13 · 2025-09-10T14:39:50Z

As mentioned in the original issue: Looks like UniGetUI 3.3.3 just released and that one installs fine (no need for the PR associated to this issue).

bucket/unigetui.json

z-Fng · 2025-10-15T17:50:51Z

/verify

github-actions · 2025-10-15T17:53:55Z

All changes look good.

Wait for review from human collaborators.

unigetui

Check the full log for details.

z-Fng · 2025-10-15T18:06:27Z

Looks like there is a bug in GitHub Actions... Hotfix needed (ae77d70).

All changes look good.

Autoupdate Hash Extraction (?)

Relates to #16054

[email protected]: use zip version to fix broken install

7fc457a

Becuase UniGetUI.Installer.exe does not seem to be using InnoSetup anymore (innounp doesn't manage to unpack it). Fixes ScoopInstaller#16053

github-actions bot added the review-needed label Aug 25, 2025

[email protected]: fix autoupdate

76abf55

Update unigetui.json to 3.3.3

66b1b27

val1984 changed the title ~~[email protected]: use zip version to fix broken install~~ [email protected]: use zip version to fix broken install Sep 10, 2025

Merge branch 'master' into patch-3

a39bc86

coderabbitai bot reviewed Sep 10, 2025

View reviewed changes

bucket/unigetui.json Outdated Show resolved Hide resolved

z-Fng reviewed Oct 9, 2025

View reviewed changes

bucket/unigetui.json Show resolved Hide resolved

z-Fng added the waiting feedback Waiting for user feedback label Oct 12, 2025

Merge branch 'master' into patch-3

3a46f51

z-Fng removed the waiting feedback Waiting for user feedback label Oct 14, 2025

z-Fng added 2 commits October 14, 2025 15:03

Fix hash, checkver & autoupdate

440932f

Update UniGetUI JSON metadata and structure

55eeb3a

z-Fng changed the title ~~[email protected]: use zip version to fix broken install~~ [email protected]: Use ZIP package, restrict to 64-bit architecture Oct 15, 2025

z-Fng changed the title ~~[email protected]: Use ZIP package, restrict to 64-bit architecture~~ [email protected]: Switch to ZIP package, add architecture field to support 64-bit only Oct 15, 2025

z-Fng merged commit 8fc987f into ScoopInstaller:master Oct 15, 2025
3 checks passed

z-Fng added a commit that referenced this pull request Oct 15, 2025

[email protected]: Fix autoupdate hash extraction

ae77d70

Relates to #16054

z-Fng mentioned this pull request Oct 15, 2025

[Bug] Manifest consistency not checked before/after autoupdate ScoopInstaller/GithubActions#63

Open

coderabbitai bot mentioned this pull request Oct 16, 2025

zed: Update to version 0.208.4, switch to official release #16346

Merged

2 tasks

coderabbitai bot mentioned this pull request Oct 30, 2025

[email protected]: Fix extract_dir, add architecture field to support 64-bit only #16505

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[email protected]: Switch to ZIP package, add architecture field to support 64-bit only #16054

[email protected]: Switch to ZIP package, add architecture field to support 64-bit only #16054

Uh oh!

val1984 commented Aug 25, 2025 •

edited by z-Fng

Loading

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

val1984 commented Aug 26, 2025

Uh oh!

github-actions bot commented Aug 26, 2025

Uh oh!

coderabbitai bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Skylark13 commented Sep 10, 2025

Uh oh!

Uh oh!

z-Fng commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

Uh oh!

z-Fng commented Oct 15, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[email protected]: Switch to ZIP package, add architecture field to support 64-bit only #16054

[email protected]: Switch to ZIP package, add architecture field to support 64-bit only #16054

Uh oh!

Conversation

val1984 commented Aug 25, 2025 • edited by z-Fng Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

github-actions bot commented Aug 25, 2025

unigetui

Uh oh!

val1984 commented Aug 26, 2025

Uh oh!

github-actions bot commented Aug 26, 2025

unigetui

Uh oh!

coderabbitai bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Pre-merge checks (4 passed, 1 warning)

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Skylark13 commented Sep 10, 2025

Uh oh!

Uh oh!

z-Fng commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

unigetui

Uh oh!

Uh oh!

z-Fng commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

val1984 commented Aug 25, 2025 •

edited by z-Fng

Loading

coderabbitai bot commented Sep 10, 2025 •

edited

Loading

z-Fng commented Oct 15, 2025 •

edited

Loading