Skip to content

Conversation

@Vixb1122
Copy link
Contributor

@Vixb1122 Vixb1122 commented Oct 23, 2025

Remove-Item: D:\Scoop\apps\scoop\current\lib\install.ps1:213
Line |
 213 |                      Remove-Item -Path "$shimdir\$name.exe"
     |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find path 'D:\Scoop\shims\zed.exe' because it does not exist.
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated binary configuration to simplify application entry point specification.

@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Walkthrough

The bin field in bucket/zed.json is changed from an array containing two executable paths to a single string path, specifically "bin\\zed.exe".

Changes

Cohort / File(s) Change Summary
Zed configuration
bucket/zed.json
Modified "bin" field from array format ["bin\\zed", "bin\\zed.exe"] to single string value "bin\\zed.exe"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

review-needed

Suggested reviewers

  • chawyehsu

Poem

🐰 A single path now leads our Zed,
No branching ways, just one thread,
The executable stands alone and true,
Simpler config—a cleaner view! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title "[email protected]: Fix shims" is thematically related to the PR objectives—addressing a shim-related error in the installation process—but it lacks specificity about the actual code change. The changeset shows a modification to the "bin" field in bucket/zed.json, where an array of two paths is replaced with a single string path. However, the title uses vague language ("Fix") that doesn't clearly convey what was changed or how the modification resolves the issue. While the version number provides helpful context, the title doesn't summarize the main technical change in a way that would clearly communicate the modification to someone scanning the pull request history. Consider revising the title to be more specific about the change itself, such as "[email protected]: Use single bin path instead of array" or "[email protected]: Simplify bin configuration to resolve shim errors." This would make it clearer for reviewers and future readers what technical change was made and why it matters.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description includes the required template elements: issue references using "Closes #16441" and "Relates to #16346", confirmation that both checkboxes have been completed (conventional PR title usage and reading the Contributing Guide), and context about the specific error being fixed. The author has followed the mandatory template structure by providing issue links and confirming adherence to contribution guidelines. While the description could be more detailed about the actual fix implementation (changing the "bin" field from an array to a single string), the required template components are present and the description adequately conveys the problem being addressed.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

zed

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd30672 and 2e7c6b6.

📒 Files selected for processing (1)
  • bucket/zed.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: qyurila
PR: ScoopInstaller/Extras#16346
File: bucket/zed.json:18-21
Timestamp: 2025-10-16T06:32:15.420Z
Learning: The Zed Windows application has three separate executables after InnoSetup extraction:
- `zed.exe` at root: GUI application (used in shortcuts)
- `bin/zed`: Shell script for WSL integration
- `bin/zed.exe`: Zed CLI binary with different behavior than the GUI
All three should be preserved in the manifest.
📚 Learning: 2025-10-16T06:32:15.420Z
Learnt from: qyurila
PR: ScoopInstaller/Extras#16346
File: bucket/zed.json:18-21
Timestamp: 2025-10-16T06:32:15.420Z
Learning: The Zed Windows application has three separate executables after InnoSetup extraction:
- `zed.exe` at root: GUI application (used in shortcuts)
- `bin/zed`: Shell script for WSL integration
- `bin/zed.exe`: Zed CLI binary with different behavior than the GUI
All three should be preserved in the manifest.

Applied to files:

  • bucket/zed.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@z-Fng z-Fng changed the title zed: fix Remove-Item error [email protected]: Fix shims Oct 23, 2025
@z-Fng z-Fng changed the title [email protected]: Fix shims [email protected]: Fix shims Oct 23, 2025
@z-Fng z-Fng changed the title [email protected]: Fix shims [email protected]: Fix shims Oct 23, 2025
@z-Fng z-Fng merged commit f99bc03 into ScoopInstaller:master Oct 23, 2025
4 checks passed
@Vixb1122 Vixb1122 deleted the zed branch October 23, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: zed - Remove-Item error occurs during update/uninstall

2 participants