Improve messages, hide size from Researchers, disallow characters and fix regex #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il-error Correct response when email validation fails during project creation
Fix the dark mode switch behaviour
…j-bug Forbid superadmin from creating project
…om project descriptions
…le, description or principal investigator fields.
This patch hides the "Size" and "total_size" variables according to the role and project status. Signed-off-by: Zishan Mirza <[email protected]>
Issue1007 input validation
Signed-off-by: Zishan Mirza <[email protected]>
Fix regex for file rm/ls
This patch adds roles to the condition of the "if" statement. Signed-off-by: Zishan Mirza <[email protected]>
Rewite login page to use component, nicer HTML styling.
Signed-off-by: Zishan Mirza <[email protected]>
Size column
…roject is a unit user.
clarify in user activation
AddUser: Specific error message for unit users
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 87.77% 87.50% -0.27%
==========================================
Files 27 27
Lines 2928 2961 +33
==========================================
+ Hits 2570 2591 +21
- Misses 358 370 +12
Continue to review full report at Codecov.
|
i-oden
requested review from
ewels,
MatthiasZepper,
alneberg,
talavis,
valyo and
a user
talavis
approved these changes
Mar 9, 2022
talavis
reviewed
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be up and running before the cli is released after ScilifelabDataCentre/dds_cli#374.
Improved messages to users:
Disallow specific characters that may mess with queries:
Fix regex for listing and deleting files: Fix regex for file rm/ls #1029
Hide the
Sizecolumn when a researcher is trying to list a project which is not Available:dds lsshowing strange numbers #1032Tests passing
Black formatting
[ - ] Migrations for any changes to the database schema
[ - ] Rebase/merge the
devbranch[ - ] Note in the CHANGELOG