Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddUser: Specific error message for unit users #1039

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

MatthiasZepper
Copy link
Contributor

@MatthiasZepper MatthiasZepper commented Mar 9, 2022

Distinct error message if the user to be added to a project is a unit user.

  • Tests passing
  • Black formatting
  • [ - ] Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@i-oden
Copy link
Member

i-oden commented Mar 9, 2022

@MatthiasZepper which card is this connected to?

@i-oden i-oden added the should have Important but not vital label Mar 9, 2022
@MatthiasZepper
Copy link
Contributor Author

@MatthiasZepper which card is this connected to?

None. This afternoon, we both - Sofia and me - were puzzled when she couldn't invite me to the system because I still had a lingering, yet expired, invite for a unit user and the error message rather indicated a typo in the specified user role. It was quicker to fix right away than to generate a card for it first...

@i-oden
Copy link
Member

i-oden commented Mar 9, 2022

@MatthiasZepper which card is this connected to?

None. This afternoon, we both - Sofia and me - were puzzled when she couldn't invite me to the system because I still had a lingering, yet expired, invite for a unit user and the error message rather indicated a typo in the specified user role. It was quicker to fix right away than to generate a card for it first...

@MatthiasZepper Then Phil has already created a PR for this #1036

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1039 (84c9d4c) into dev (d57f2c5) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

❗ Current head 84c9d4c differs from pull request most recent head fcc56e5. Consider uploading reports for the commit fcc56e5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1039      +/-   ##
==========================================
- Coverage   87.58%   87.55%   -0.03%     
==========================================
  Files          27       27              
  Lines        2955     2957       +2     
==========================================
+ Hits         2588     2589       +1     
- Misses        367      368       +1     
Impacted Files Coverage Δ
dds_web/api/user.py 87.39% <66.66%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57f2c5...fcc56e5. Read the comment docs.

@i-oden i-oden marked this pull request as ready for review March 9, 2022 16:46
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍🏻

@i-oden i-oden merged commit 4549858 into ScilifelabDataCentre:dev Mar 9, 2022
@MatthiasZepper MatthiasZepper deleted the AddUnitUserErrorMsg branch June 7, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
should have Important but not vital
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants