Size column #1023
Merged
Size column #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2022 12:13
This patch hides the "Size" and "total_size" variables according to the role and project status. Signed-off-by: Zishan Mirza <[email protected]>
Signed-off-by: Zishan Mirza <[email protected]>
Codecov Report
@@ Coverage Diff @@
## dev #1023 +/- ##
==========================================
+ Coverage 87.59% 87.61% +0.01%
==========================================
Files 27 27
Lines 2943 2946 +3
==========================================
+ Hits 2578 2581 +3
Misses 365 365
Continue to review full report at Codecov.
|
i-oden
reviewed
Mar 8, 2022
|
@zishanmirza Can you also add a row to the changelog? |
This patch updates "CHANGELOG.md" and switches the condition in the "if" statement to "total_size". Signed-off-by: Zishan Mirza <[email protected]>
|
I have updated CHANGELOG.md. |
i-oden
reviewed
Mar 9, 2022
i-oden
requested changes
Mar 9, 2022
i-oden
reviewed
Mar 9, 2022
added 2 commits
March 9, 2022 12:52
This patch adds roles to the condition of the "if" statement. Signed-off-by: Zishan Mirza <[email protected]>
Signed-off-by: Zishan Mirza <[email protected]>
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch hides the "Size" and "total_size" variables according to the role and project status.
Fixes #1008.
devbranch