Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for new version release before summer 2022 #501

Merged
merged 56 commits into from
Jun 29, 2022
Merged

Prep for new version release before summer 2022 #501

merged 56 commits into from
Jun 29, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Jun 27, 2022

Description

This is a PR for the next version of the DDS CLI and contains the following major changes.

  • Add new message of the day and display the latest one automatically.

  • Add version to header in all requests

  • Change in python version

  • Summary of the changes and the related issue

  • Relevant motivation and context

  • Any dependencies that are required for this change

Fixes X

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Product Owner / Scrum Master: This PR is made to the master branch and I have updated the version

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #501 (baebd50) into master (f146d48) will increase coverage by 34.25%.
The diff coverage is 55.73%.

@@             Coverage Diff             @@
##           master     #501       +/-   ##
===========================================
+ Coverage    7.15%   41.41%   +34.25%     
===========================================
  Files          29       29               
  Lines        2487     2528       +41     
===========================================
+ Hits          178     1047      +869     
+ Misses       2309     1481      -828     
Impacted Files Coverage Δ
dds_cli/auth.py 41.17% <ø> (+41.17%) ⬆️
dds_cli/base.py 43.01% <ø> (+43.01%) ⬆️
dds_cli/user.py 19.07% <25.00%> (+19.07%) ⬆️
dds_cli/account_manager.py 33.33% <26.66%> (+33.33%) ⬆️
dds_cli/__main__.py 41.22% <47.05%> (+41.22%) ⬆️
dds_cli/motd_manager.py 78.57% <85.71%> (+78.57%) ⬆️
dds_cli/__init__.py 91.78% <100.00%> (+0.11%) ⬆️
dds_cli/utils.py 100.00% <100.00%> (+55.17%) ⬆️
dds_cli/version.py 100.00% <100.00%> (ø)
dds_cli/exceptions.py 80.43% <0.00%> (+8.69%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f146d48...baebd50. Read the comment docs.

@i-oden i-oden self-assigned this Jun 27, 2022
@i-oden i-oden added the master label Jun 27, 2022
@i-oden i-oden marked this pull request as draft June 28, 2022 06:28
@i-oden i-oden marked this pull request as ready for review June 29, 2022 12:40
@i-oden i-oden requested a review from valyo June 29, 2022 13:30
@i-oden i-oden merged commit ca01310 into master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants