Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List all users as superadmin #504

Merged
merged 9 commits into from
Jun 29, 2022
Merged

List all users as superadmin #504

merged 9 commits into from
Jun 29, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Jun 28, 2022

Description

List all users as super admin, and find users if they exist.

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Product Owner / Scrum Master: This PR is made to the master branch and I have updated the version

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@i-oden i-oden self-assigned this Jun 28, 2022
@i-oden i-oden requested a review from valyo June 28, 2022 14:32
@i-oden i-oden marked this pull request as ready for review June 28, 2022 14:32
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #504 (5692424) into dev (1743bdb) will increase coverage by 30.13%.
The diff coverage is 35.71%.

@@             Coverage Diff             @@
##              dev     #504       +/-   ##
===========================================
+ Coverage   11.27%   41.40%   +30.13%     
===========================================
  Files          29       29               
  Lines        2502     2526       +24     
===========================================
+ Hits          282     1046      +764     
+ Misses       2220     1480      -740     
Impacted Files Coverage Δ
dds_cli/utils.py 100.00% <ø> (+0.55%) ⬆️
dds_cli/account_manager.py 33.33% <26.66%> (+33.33%) ⬆️
dds_cli/__main__.py 41.12% <36.36%> (+41.12%) ⬆️
dds_cli/__init__.py 91.78% <100.00%> (+0.11%) ⬆️
dds_cli/data_lister.py 13.61% <0.00%> (+13.61%) ⬆️
dds_cli/user.py 19.18% <0.00%> (+19.18%) ⬆️
dds_cli/data_putter.py 22.79% <0.00%> (+22.79%) ⬆️
dds_cli/file_handler_local.py 23.36% <0.00%> (+23.36%) ⬆️
dds_cli/file_handler_remote.py 26.00% <0.00%> (+26.00%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1743bdb...5692424. Read the comment docs.

Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine

@i-oden i-oden merged commit 127e724 into dev Jun 29, 2022
@i-oden i-oden deleted the list-all-users-as-superadmin branch June 29, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants