Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version header fix #496

Merged
merged 9 commits into from
Jun 3, 2022
Merged

Version header fix #496

merged 9 commits into from
Jun 3, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented May 30, 2022

Description

Cloned #495 and changed slightly.

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes DDS-1259

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Product Owner / Scrum Master: This PR is made to the master branch and I have updated the version

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Zishan Mirza and others added 3 commits May 23, 2022 13:20
This patch adds the version header.

Fixes DDS-1259.

Signed-off-by: Zishan Mirza <[email protected]>
@i-oden i-oden self-assigned this May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #496 (caf1eb2) into dev (e376e90) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #496      +/-   ##
==========================================
+ Coverage   11.17%   11.32%   +0.14%     
==========================================
  Files          29       29              
  Lines        2487     2491       +4     
==========================================
+ Hits          278      282       +4     
  Misses       2209     2209              
Impacted Files Coverage Δ
dds_cli/auth.py 0.00% <ø> (ø)
dds_cli/user.py 0.00% <ø> (ø)
dds_cli/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e376e90...caf1eb2. Read the comment docs.

@i-oden i-oden requested a review from valyo June 3, 2022 05:28
Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine

@i-oden i-oden merged commit ae3aa89 into dev Jun 3, 2022
@i-oden i-oden deleted the version_header_fix branch June 3, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants