migrate travis-ci to cirrus-ci#66
Conversation
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=========================================
Coverage ? 89.14%
=========================================
Files ? 1
Lines ? 175
Branches ? 42
=========================================
Hits ? 156
Misses ? 13
Partials ? 6 Continue to review full report at Codecov.
|
defc2fc to
78b7e6e
Compare
lbdreyer
left a comment
There was a problem hiding this comment.
Looking good so far! A really great improvement!
I have a few minor things to look through (I'll do these tomorrow) but I thought I'd submit the few minor comments I had so far
|
Looks like this is good to go! Thanks for working on this @bjlittle ! |
|
@lbdreyer Awesome! 🥳 🍻 |
| - conda-forge | ||
|
|
||
| dependencies: | ||
| - python 3.9 |
There was a problem hiding this comment.
Do we need an env file for each Python version? That will be an extra burden to maintain :-/
| 1, | ||
| 1, | ||
| calendar=self.calendar, | ||
| **has_year_zero(year), |
There was a problem hiding this comment.
Sorry not to have caught this before merge. has_year_zero was only introduced as a kwarg in Unidata/cftime#234, which means the cftime requirement should be pinned: cftime>=1.5.
(I think this ought to fix the nc-time-axis failures on SciTools/iris#4194, although it's hard to tell if it's the root cause).
🚀 Pull Request
Description
This PR shows some much need ❤️ to
nc-time-axis.For fuller details see the associated Issue #63.
Note that, in order to reboot the CI, I've folding in the following awesome contributions:
This PR will also close:
Closes #63