Improve handling of scalars in NetCDFTimeConverter.convert#46
Merged
bjlittle merged 2 commits intoSciTools:masterfrom Jun 10, 2021
Merged
Improve handling of scalars in NetCDFTimeConverter.convert#46bjlittle merged 2 commits intoSciTools:masterfrom
bjlittle merged 2 commits intoSciTools:masterfrom
Conversation
Member
|
@spencerkclark Once #66 lands (hopefully), you'll need to rebase, then I'll review and merge 👍 |
Member
|
@spencerkclark Time to rebase 👍 Then let's get this finally banked 😃 |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 89.14% 89.08% -0.07%
==========================================
Files 1 1
Lines 175 174 -1
Branches 42 42
==========================================
- Hits 156 155 -1
Misses 13 13
Partials 6 6
Continue to review full report at Codecov.
|
Member
Author
Member
|
I'll get to this, this evening 👍 Awesome! |
bjlittle
reviewed
Jun 10, 2021
bjlittle
approved these changes
Jun 10, 2021
Member
|
@spencerkclark Perfect, thanks 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a simple fix for #45.